Bug fixes with pagination #2016

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

dmmihaylov commented Nov 20, 2012

  1. First url wasn't using suffix.
  2. There was a bug with adding existing get parameters to paging links.
@dmmihaylov dmmihaylov Bug fixes with pagination
1. First url wasn't using suffix.
2. There was a bug with adding existing get parameters to paging links.
8c02a1c

@narfbg narfbg commented on the diff Nov 20, 2012

system/libraries/Pagination.php
}
// Render the "First" link
if ($this->first_link !== FALSE && $this->cur_page > ($this->num_links + 1))
{
- $first_url = ($this->first_url === '') ? $this->base_url : $this->first_url;
+ $first_url = ($this->first_url === '') ? $this->prefix.$this->base_url.$this->suffix : $this->first_url;
@narfbg

narfbg Nov 20, 2012

Contributor

This is a separate issue and some would argue if there should be a prefix for it or not ... let's keep this one limited to the query string part.

P.S.: Just commit and push the changes to the same branch, you don't need to close and create another pull request.

narfbg referenced this pull request Nov 22, 2012

Closed

Pagination bug fix #2012

Contributor

narfbg commented Nov 22, 2012

Manually applied the ? vs. & change.
The other one won't get in though, see my comment on it here: EllisLab#1414 (comment)

narfbg closed this Nov 22, 2012

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@narfbg narfbg Manually apply a fix submitted via PR #2012, #2016 926b304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment