Session_cookie driver #2033

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@williamknauss
Contributor

williamknauss commented Nov 26, 2012

Fixed a typo in the session_cookie driver that prevented it from
loading. Line 222 removed one equal sign from the if statement.

Session_cookie driver
Fixed a typo in the session_cookie driver that prevented it from
loading. Line 222 removed one equal sign from the if statement.
@appleboy

This comment has been minimized.

Show comment Hide comment
@appleboy

appleboy Nov 26, 2012

Contributor

This is not correct pull request.

Contributor

appleboy commented Nov 26, 2012

This is not correct pull request.

narfbg added a commit that referenced this pull request Nov 26, 2012

Manually implement PR #2033
Check for an empty encryption_key shouldn't use strict comparison.
@narfbg

This comment has been minimized.

Show comment Hide comment
@narfbg

narfbg Nov 26, 2012

Contributor

Good thing there was a proper description. :)
Thanks, @williamknauss 4abd094

Contributor

narfbg commented Nov 26, 2012

Good thing there was a proper description. :)
Thanks, @williamknauss 4abd094

@williamknauss

This comment has been minimized.

Show comment Hide comment
@williamknauss

williamknauss Nov 26, 2012

Contributor

@narfbg can you tell me why git thinks I made 844 changes to session_cookie_driver?

Contributor

williamknauss commented Nov 26, 2012

@narfbg can you tell me why git thinks I made 844 changes to session_cookie_driver?

@narfbg

This comment has been minimized.

Show comment Hide comment
@narfbg

narfbg Nov 26, 2012

Contributor

@williamknauss You're probably using an IDE that re-writes tabs to spaces or line endings, so it's not git that thinks so - you are in fact changing every single line, only you don't see any visual difference.

Contributor

narfbg commented Nov 26, 2012

@williamknauss You're probably using an IDE that re-writes tabs to spaces or line endings, so it's not git that thinks so - you are in fact changing every single line, only you don't see any visual difference.

@williamknauss

This comment has been minimized.

Show comment Hide comment
@williamknauss

williamknauss Nov 26, 2012

Contributor

Other than the tab rewrite was there anything else actually wrong with this pull request as appleboy said?

Contributor

williamknauss commented Nov 26, 2012

Other than the tab rewrite was there anything else actually wrong with this pull request as appleboy said?

@narfbg

This comment has been minimized.

Show comment Hide comment
@narfbg

narfbg Nov 26, 2012

Contributor

Turns out the problem is with line endings and not tabs vs. spaces. Other than that I don't see a problem, but that is wrong enough.

Contributor

narfbg commented Nov 26, 2012

Turns out the problem is with line endings and not tabs vs. spaces. Other than that I don't see a problem, but that is wrong enough.

nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

Manually implement PR #2033
Check for an empty encryption_key shouldn't use strict comparison.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment