Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Resolves issue #2081 : Foreign Key Checks #2087

Merged
merged 3 commits into from Dec 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

AndrewPodner commented Dec 19, 2012

provides an option to include statements to disable and re-enable foreign key checks in a MySQL database backup output statement.

@AndrewPodner AndrewPodner Resolves issue #2081 : provides an option to include statements to di…
…sable and re-enable foreign key checks in a MySQL database backup output statement.
79494dd
Contributor

narfbg commented Dec 20, 2012

Looks good, but it would need a changelog entry to be added as well - could you do that?

I'm also not sure if 'fk_checks' is descriptive enough and from my experience, there are a lot of people that would care about this. Probably change it to 'foreign_key_checks' like it is actually presented in MySQL?

Edit: Just to clarify - the changelog entry should be listed as a new feature, not a bugfix.

@AndrewPodner AndrewPodner fixes #2081 : change parameter/variable name to 'foreign_key_checks',…
… update change log

Signed-off-by:Andrew Podner <a.podner@me.com>
4851217
Contributor

AndrewPodner commented Dec 20, 2012

This should clear it up. Not sure if I put it in the right part of the changelog.

Contributor

narfbg commented Dec 20, 2012

Um, not really - you should list it under the Database Utility changes (the line where you're also fixing a typo).

@AndrewPodner AndrewPodner fixes #2081 : fix change log entry
Signed-off-by:Andrew Podner <a.podner@me.com>
bee50e7
Contributor

AndrewPodner commented Dec 20, 2012

done

@narfbg narfbg added a commit that referenced this pull request Dec 20, 2012

@narfbg narfbg Merge pull request #2087 from AndrewPodner/develop
Resolves issue #2081 : Foreign Key Checks
16c26ff

@narfbg narfbg merged commit 16c26ff into bcit-ci:develop Dec 20, 2012

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@narfbg narfbg Merge pull request #2087 from AndrewPodner/develop
Resolves issue #2081 : Foreign Key Checks
12d7361

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@narfbg narfbg [ci skip] Minor style/spacing changes following PR #2087 38915af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment