Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Issue #217: Parser becomes a driver #2103

Merged
merged 0 commits into from

3 participants

@ragboyjr

This should be all we need to complete this issue. Now, I've written actual drivers for other systems, how exactly does CI offer these drivers? Do I contact each other third party template engine and have them host the driver file and instructions on how to use or is there some other solution?

@ragboyjr

K, I've been breaking my balls trying to make this pull request pass the unit tests. It's now breaking in the Driver.php file which isn't something I touched. It keeps failing when something tries to access config. A little help in this area would be greatly appreciated.

Thanks,

RJ

@ragboyjr ragboyjr referenced this pull request
Open

Parser becomes a driver #217

@ragboyjr ragboyjr merged commit 85adeed into bcit-ci:develop

1 check passed

Details default The Travis build passed
@narfbg
Owner

Why did you close this?

@ragboyjr

Honestly, I didn't mean to close it. I was cleaning up and updating my forked repo, and I must have accidentally closed it. But I figured because I threw so many commits on this, and because my commits stopped going through Travis CI that it was dead. I need to install php-unit and vfs on my computer too, so that I don't have to run up the commits. I figured when I did that, I'd make a new pull request.
But it's your guys' repo, so let me know how and what you want me to do so that I may contribute best.

@narfbg
Owner

Travis isn't really reliable these days and it tends to erroneously report an error on pretty much every commit, either because it failed to fetch a required library or with a "Segmentation fault" error.

@ragboyjr

Ok, I don't know if I can open the ticket once it's been closed. Let me know if you want me to make a new ticket or if I should just wait till someone reopens this one

@narfbg
Owner

I can reopen, but the diff is gone ... no point in doing that. Please resubmit it. :)

@williamknauss

@ragboyjr are you still working on this?

@ragboyjr

Yup, I reopened at #2158, don't know what else needs to be done to get this going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 0 deletions.
Something went wrong with that request. Please try again.