Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User Agents #5536

Closed
wants to merge 1 commit into from
Closed

Update User Agents #5536

wants to merge 1 commit into from

Conversation

elminson
Copy link

'MALGJS' means LG OEM Windows Devices. (like a notebook) with Windows 10 but detected as mobile.
but IE11 browser in LG OEM devices with Windows 10 agent value like this:
Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; MALGJS; rv:11.0) like Gecko

'MALGJS' means LG OEM Windows Devices. (like a notebook) with Windows 10 but detected as mobile.
but IE11 browser in LG OEM devices with Windows 10 agent value like this:
Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; MALGJS; rv:11.0) like Gecko
@gxgpet
Copy link
Contributor

gxgpet commented Jun 25, 2018

Relates to #4461?

@elminson
Copy link
Author

Yes @gxgpet

@elminson
Copy link
Author

Can you check this PR @gxgpet?

@gxgpet
Copy link
Contributor

gxgpet commented Jun 25, 2018

Well, there are some things here regarding this...

The reason that user_agents.php file is located under application/config it's because it's a configuration file, meaning its aim is to be edited by the CI developer, if necessary. So, if you spot something which is targetting your audience, then there you go, you change this file.

It is also true that user_agents.php tries to add as many scenarios as possible. Yet, it should maintain a generic purpose list, not tailored to some specific cases, and to be honest, "LG OEM Windows Devices" looks a bit like a particular scenario, not a generic one.

However, since this is the second time this issue is reported, there could be some reflection for deciding whether or not this should be added.

Anyway, you should wait for some official feedback (mine isn't) here, for this PR.

@elminson
Copy link
Author

Thanks for the feedback! Waiting for official feedback.

@narfbg
Copy link
Contributor

narfbg commented Jul 22, 2018

Well, technically this isn't the "second time this issue is reported", but rather @elminson trying to resolve #4461 (and only with the info available in that issue, I would say).

"LG OEM Windows Devices" is not a browser brand name, so listing it under $browsers is definitely erroneous. At best it belongs under $platforms or $mobiles, but even then it would stand out as quite dissimilar compared to the types of other names listed.

@narfbg narfbg closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants