fixing cookie problem : issues #33 #794

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

fixing cookie problem : issues #33

{
if ( ! preg_match("/^[a-z0-9:_\/-]+$/i", $str))
{
- exit('Disallowed Key Characters.');
+ //if $cookie true will unset it
+ if($cookie)
@AmineCherrai

AmineCherrai Dec 17, 2011

if the cookie is 'dirty' we just unset it

@@ -616,11 +616,19 @@ private function _clean_input_data($str)
* @param string
* @return string
*/
- private function _clean_input_keys($str)
+ private _clean_input_keys($str , $cookie = false)
@AmineCherrai

AmineCherrai Dec 17, 2011

private _clean_input_keys($str , $cookie = false)

if $str is a 'cookie', $cookie should be true to not get crash when while cookie is not clean

@it-can

it-can Dec 17, 2011

Contributor

It should be: private function

@AmineCherrai

AmineCherrai Dec 18, 2011

thanks for notifying me

@@ -554,14 +554,14 @@ private function _sanitize_globals()
* @param string
* @return string
*/
- private function _clean_input_data($str)
+ private _clean_input_data($str, $cookie = false)
@it-can

it-can Dec 17, 2011

Contributor

It shoud be: private function

Contributor

it-can commented Dec 18, 2011

Your functions don't work because you forget the word "function" after "private"

Contributor

it-can commented Dec 21, 2011

Can you update your code so it can be merged...

Contributor

gaker commented Dec 28, 2011

Generally speaking, functions and class vars in core code can't be private so developers are able to extend them as they please.

Contributor

it-can commented Jan 9, 2012

I did a rewrite of your pull request: EllisLab#902

@it-can it-can referenced this pull request Jun 8, 2012

Closed

Rewrite fix issue #33 #902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment