I added an argument in the read_file function to enable users to rename ... #884

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@desduvauchelle

...the files that they are about to zip. I was thinking of this when I was implementing a sort of gmail download where each file names are encoded and then zipped to be downloaded.

I added an argument in the read_file function to enable users to rena…
…me the files that they are about to zip. I was thinking of this when I was implementing a sort of gmail download where each file names are encoded and then zipped to be downloaded.
@@ -260,17 +260,20 @@ function read_file($path, $preserve_filepath = FALSE)
if (FALSE !== ($data = file_get_contents($path)))
{
- $name = str_replace("\\", "/", $path);
+ if($name == NULL)

This comment has been minimized.

Show comment Hide comment
@philsturgeon

philsturgeon Jan 8, 2012

Contributor

Please can you put a space between the if and the (.

@philsturgeon

philsturgeon Jan 8, 2012

Contributor

Please can you put a space between the if and the (.

@beaucharman

This comment has been minimized.

Show comment Hide comment
@beaucharman

beaucharman Apr 17, 2013

Would be awesome to get this committed

Would be awesome to get this committed

narfbg added a commit that referenced this pull request Jan 7, 2014

@narfbg narfbg closed this Jan 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment