Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added date_range() to the Date helper #918

Merged
merged 21 commits into from Oct 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

narfbg commented Jan 11, 2012

This was requested in uservoice and is marked as planned. I've also needed something like this once in a while, so ... here it is.

Contributor

narfbg commented May 2, 2012

@philsturgeon Other than that it needs to be synced, any comments on this one? My only concern is wether it should be based on UNIX timestamps, but it was suggested to be in the referenced uservoice and parsing formatted dates can be tricky anyway.

Contributor

alexbilbie commented Aug 31, 2012

I'm just going through old tickets - I think in the interest of keeping the function nice and simple (and as you said, parsing formatted dates can be tricky) stick with unix timestamps. Plus there are already a couple of functions in the date helper that can help with conversion from formatted dates to unix timestamps.

I think if you can add a unit test to the date helper test we should merge it in.

narfbg added a commit that referenced this pull request Oct 5, 2012

Merge pull request #918 from narfbg/develop-dh-date-range
Added date_range() to the Date helper

@narfbg narfbg merged commit dc9bfb7 into bcit-ci:develop Oct 5, 2012

nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

Merge pull request #918 from narfbg/develop-dh-date-range
Added date_range() to the Date helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment