Improve the PostgreSQL database driver #981

Merged
merged 28 commits into from Apr 26, 2012

2 participants

@narfbg

Changes include:

  • Speed improvements
  • General clean up
@toopay toopay and 1 other commented on an outdated diff Jan 27, 2012
system/database/drivers/postgre/postgre_driver.php
/**
* The syntax to count rows is slightly different across different
* database engines, so this string appears in each driver and is
* used for the count_all() and count_all_results() functions.
*/
- var $_count_string = "SELECT COUNT(*) AS ";
- var $_random_keyword = ' RANDOM()'; // database specific random keyword
+ protected $_count_string = 'SELECT COUNT(*) AS ';
+ protected $_random_keyword = ' RANDOM()'; // database specific random keyword
+
+ // Postgre-specific properties
+ protected $_pg_dsn;
@toopay
toopay added a line comment Jan 27, 2012

It looks like that the proposal to have dsn as additional value on config on #955, could be re-used somewhere else here. :)

@narfbg
narfbg added a line comment Jan 27, 2012

Yes - I've noted that in the pull description. :)

@narfbg
narfbg added a line comment Feb 12, 2012

Updated to use dsn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
narfbg added some commits Jan 27, 2012
@narfbg narfbg Remove an empty line :) c25c3d3
@narfbg narfbg Merge upstream branch and fix private methods to be protected 2b3edbd
@narfbg narfbg Merge remote-tracking branch 'upstream/develop' into develop-db-postgre 1de34ff
@narfbg narfbg Merge remote-tracking branch 'upstream/develop' into develop-db-postgre d27c20a
@narfbg narfbg Merge remote-tracking branch 'upstream/develop' into develop-db-postgre d267e35
@narfbg narfbg Improve DSN string support a64c61a
@narfbg narfbg Use protect_identifiers() instead of _escape_identifiers() in CI_DB_p…
…ostgre_forge
2854724
@narfbg narfbg Merge upstream branch 97d4c29
@narfbg narfbg Merge upstream branch 2fc3714
@narfbg narfbg Merge remote-tracking branch 'upstream/develop' into develop-db-postgre 386c089
@narfbg narfbg Merge upstream branch 718d9ef
@narfbg narfbg Merge upstream branch 8335a5d
@narfbg narfbg Remove pg_set_client_encoding() from db_connect(), db_pconnect() a6a1496
@narfbg narfbg Merge upstream branch 4cc7269
@narfbg narfbg Merge upstream branch 5f2214f
@narfbg narfbg Merge upstream branch fd70ceb
@narfbg narfbg Remove EOF newlines 135efb2
@narfbg narfbg Merge upstream branch 12ddc49
@narfbg narfbg Merge branch 'develop' of github.com:EllisLab/CodeIgniter into develo…
…p-db-postgre
8aea4f4
@narfbg narfbg Merge branch 'develop' of github.com:EllisLab/CodeIgniter into develo…
…p-db-postgre
5b46f42
@narfbg narfbg Merge branch 'develop' of github.com:EllisLab/CodeIgniter into develo…
…p-db-postgre
fd105ab
@narfbg narfbg Merge upstream branch fcdfcf9
@narfbg narfbg Update _delete() and _update() with removal of unsupported LIMIT and …
…ORDER BY
82e88b9
@narfbg narfbg Merge upstream branch 697bf3f
@narfbg narfbg Merge branch 'develop' of github.com:EllisLab/CodeIgniter into develo…
…p-db-postgre
ab77185
@narfbg narfbg Add back an unused argument to _delete() due to CI_DB_driver being ab…
…stract
fb61edc
@philsturgeon philsturgeon merged commit 61318a2 into bcit-ci:develop Apr 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment