Add option to automatically attach inline images in HTML email messages #990

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@barrymieny
Contributor

Added 'inline_images' and 'image_path' preferences. Changed 'attach' function to return Content ID with new '_get_content_id' function when disposition is 'inline'. Changed '_build_message' function to automatically attach inline images if preferences are set.

@barrymieny barrymieny Add option to automatically attach inline images in HTML email messages
Added 'inline_images' and 'image_path' preferences. Changed 'attach' function to return Content ID with new '_get_content_id' function when disposition is 'inline'. Changed '_build_message' function to automatically attach inline images if preferences are set.
9260cce
@mamprogr

thanks for your addition,

but there is problem with this in email: <img src="/tmp/123.png" style="height: 23px; width: 550px" align="center" />
at line: 1014
the result of:
preg_match_all('/<.*?(src|background)\=\"(.*)\".*?>/', $this->_body, $matched_images, PREG_PATTERN_ORDER);
is /tmp/123.png" style="height: 23px; width: 550px" align="center" !!

it cause error with attach.

barrymieny added some commits Jan 27, 2012
@barrymieny barrymieny Add option to automatically attach inline images in HTML email messages
Added 'inline_images' and 'image_path' preferences. Changed 'attach' function to return Content ID with new '_get_content_id' function when disposition is 'inline'. Changed '_build_message' function to automatically attach inline images if preferences are set.
fa1786c
@barrymieny barrymieny Rebased "automatically attach inline images in HTML email messages" t…
…o newer commit
c5a812f
@barrymieny
Contributor

I've updated my fork to work with the newer commit's code. The regex has been changed somewhat to account for single and double (or no) quotes.

@barrymieny barrymieny closed this Mar 8, 2013
@ls-cory
ls-cory commented Mar 8, 2013

Thank you for taking the time to close this pull request. Any possible chance you're making a updated pull request with the functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment