Kindly replace array values with type numbers

[Akshay-Hegde]

CodeIgniter/system/database/drivers/mysqli/mysqli_utility.php

Line 159 in 6607ca2

array('tinyint', 'smallint', 'mediumint', 'int', 'bigint'), //, 'timestamp'),

http://php.net/manual/en/mysqli-result.fetch-field.php

fetch_field() returns type numbers so, kindly replace it with type number instead of name.

array( 1, 2, 9, 3, 8 )

$is_int[$i] = in_array($field->type, array( 1, 2, 9, 3, 8), TRUE);

numerics

BIT: 16
TINYINT: 1
BOOL: 1
SMALLINT: 2
MEDIUMINT: 9
INTEGER: 3
BIGINT: 8
SERIAL: 8
FLOAT: 4
DOUBLE: 5
DECIMAL: 246
NUMERIC: 246
FIXED: 246

Fixed here :

https://stackoverflow.com/questions/46178066/codigniter-backup-library-creating-wrong-insert-query/46182021#46182021

[narfbg]

Thanks for reporting this.

However, please note that you should describe the problem, not the solution ... and linking SO questions isn't appropriate for that (e.g. what if the question gets deleted? This bug report becomes meaningless).

Also, the suggested fix isn't correct as we're dealing with a bitflag field; you cannot just compare against a set of values.
For example, an int auto_increment field wouldn't have a type value of 3 (as suggested by you). It would contain at least the MYSQLI_TYPE_LONG (int) and MYSQLI_AUTO_INCREMENT_FLAG, and thus will equal at least 515.

Please use the linked commit and see if it works for you if possible.

P.S.: While in this case the OP on that StackOverflow question has no other choice, it is otherwise very inappropriate to suggest modifying core framework files.

[Akshay-Hegde]

Yeah, I understand what you said, I had referred below link and accordingly I replaced name with datatype number,

http://php.net/manual/en/mysqli-result.fetch-field.php

http://php.net/manual/en/mysqli-result.fetch-field-direct.php

Probably one can also refer mysqli constants something like below

[akshay@localhost tmp]$ php -r 'print_r(get_defined_constants(true)["mysqli"]);'
Array
(
    [MYSQLI_READ_DEFAULT_GROUP] => 5
    [MYSQLI_READ_DEFAULT_FILE] => 4
    [MYSQLI_OPT_CONNECT_TIMEOUT] => 0
    [MYSQLI_OPT_LOCAL_INFILE] => 8
    [MYSQLI_INIT_COMMAND] => 3
    [MYSQLI_OPT_NET_CMD_BUFFER_SIZE] => 202
    [MYSQLI_OPT_NET_READ_BUFFER_SIZE] => 203
    [MYSQLI_OPT_INT_AND_FLOAT_NATIVE] => 201
    [MYSQLI_OPT_SSL_VERIFY_SERVER_CERT] => 21
    [MYSQLI_SERVER_PUBLIC_KEY] => 27
    [MYSQLI_CLIENT_SSL] => 2048
    [MYSQLI_CLIENT_COMPRESS] => 32
    [MYSQLI_CLIENT_INTERACTIVE] => 1024
    [MYSQLI_CLIENT_IGNORE_SPACE] => 256
    [MYSQLI_CLIENT_NO_SCHEMA] => 16
    [MYSQLI_CLIENT_FOUND_ROWS] => 2
    [MYSQLI_CLIENT_SSL_VERIFY_SERVER_CERT] => 1073741824
    [MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT] => 64
    [MYSQLI_CLIENT_CAN_HANDLE_EXPIRED_PASSWORDS] => 4194304
    [MYSQLI_OPT_CAN_HANDLE_EXPIRED_PASSWORDS] => 29
    [MYSQLI_STORE_RESULT] => 0
    [MYSQLI_USE_RESULT] => 1
    [MYSQLI_ASYNC] => 8
    [MYSQLI_STORE_RESULT_COPY_DATA] => 16
    [MYSQLI_ASSOC] => 1
    [MYSQLI_NUM] => 2
    [MYSQLI_BOTH] => 3
    [MYSQLI_STMT_ATTR_UPDATE_MAX_LENGTH] => 0
    [MYSQLI_STMT_ATTR_CURSOR_TYPE] => 1
    [MYSQLI_CURSOR_TYPE_NO_CURSOR] => 0
    [MYSQLI_CURSOR_TYPE_READ_ONLY] => 1
    [MYSQLI_CURSOR_TYPE_FOR_UPDATE] => 2
    [MYSQLI_CURSOR_TYPE_SCROLLABLE] => 4
    [MYSQLI_STMT_ATTR_PREFETCH_ROWS] => 2
    [MYSQLI_NOT_NULL_FLAG] => 1
    [MYSQLI_PRI_KEY_FLAG] => 2
    [MYSQLI_UNIQUE_KEY_FLAG] => 4
    [MYSQLI_MULTIPLE_KEY_FLAG] => 8
    [MYSQLI_BLOB_FLAG] => 16
    [MYSQLI_UNSIGNED_FLAG] => 32
    [MYSQLI_ZEROFILL_FLAG] => 64
    [MYSQLI_AUTO_INCREMENT_FLAG] => 512
    [MYSQLI_TIMESTAMP_FLAG] => 1024
    [MYSQLI_SET_FLAG] => 2048
    [MYSQLI_NUM_FLAG] => 32768
    [MYSQLI_PART_KEY_FLAG] => 16384
    [MYSQLI_GROUP_FLAG] => 32768
    [MYSQLI_ENUM_FLAG] => 256
    [MYSQLI_BINARY_FLAG] => 128
    [MYSQLI_NO_DEFAULT_VALUE_FLAG] => 4096
    [MYSQLI_ON_UPDATE_NOW_FLAG] => 8192
    [MYSQLI_TYPE_DECIMAL] => 0
    [MYSQLI_TYPE_TINY] => 1
    [MYSQLI_TYPE_SHORT] => 2
    [MYSQLI_TYPE_LONG] => 3
    [MYSQLI_TYPE_FLOAT] => 4
    [MYSQLI_TYPE_DOUBLE] => 5
    [MYSQLI_TYPE_NULL] => 6
    [MYSQLI_TYPE_TIMESTAMP] => 7
    [MYSQLI_TYPE_LONGLONG] => 8
    [MYSQLI_TYPE_INT24] => 9
    [MYSQLI_TYPE_DATE] => 10
    [MYSQLI_TYPE_TIME] => 11
    [MYSQLI_TYPE_DATETIME] => 12
    [MYSQLI_TYPE_YEAR] => 13
    [MYSQLI_TYPE_NEWDATE] => 14
    [MYSQLI_TYPE_ENUM] => 247
    [MYSQLI_TYPE_SET] => 248
    [MYSQLI_TYPE_TINY_BLOB] => 249
    [MYSQLI_TYPE_MEDIUM_BLOB] => 250
    [MYSQLI_TYPE_LONG_BLOB] => 251
    [MYSQLI_TYPE_BLOB] => 252
    [MYSQLI_TYPE_VAR_STRING] => 253
    [MYSQLI_TYPE_STRING] => 254
    [MYSQLI_TYPE_CHAR] => 1
    [MYSQLI_TYPE_INTERVAL] => 247
    [MYSQLI_TYPE_GEOMETRY] => 255
    [MYSQLI_TYPE_JSON] => 245
    [MYSQLI_TYPE_NEWDECIMAL] => 246
    [MYSQLI_TYPE_BIT] => 16
    [MYSQLI_SET_CHARSET_NAME] => 7
    [MYSQLI_SET_CHARSET_DIR] => 6
    [MYSQLI_NO_DATA] => 100
    [MYSQLI_DATA_TRUNCATED] => 101
    [MYSQLI_REPORT_INDEX] => 4
    [MYSQLI_REPORT_ERROR] => 1
    [MYSQLI_REPORT_STRICT] => 2
    [MYSQLI_REPORT_ALL] => 255
    [MYSQLI_REPORT_OFF] => 0
    [MYSQLI_DEBUG_TRACE_ENABLED] => 0
    [MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED] => 16
    [MYSQLI_SERVER_QUERY_NO_INDEX_USED] => 32
    [MYSQLI_SERVER_QUERY_WAS_SLOW] => 2048
    [MYSQLI_SERVER_PS_OUT_PARAMS] => 4096
    [MYSQLI_REFRESH_GRANT] => 1
    [MYSQLI_REFRESH_LOG] => 2
    [MYSQLI_REFRESH_TABLES] => 4
    [MYSQLI_REFRESH_HOSTS] => 8
    [MYSQLI_REFRESH_STATUS] => 16
    [MYSQLI_REFRESH_THREADS] => 32
    [MYSQLI_REFRESH_SLAVE] => 64
    [MYSQLI_REFRESH_MASTER] => 128
    [MYSQLI_REFRESH_BACKUP_LOG] => 2097152
    [MYSQLI_TRANS_START_WITH_CONSISTENT_SNAPSHOT] => 1
    [MYSQLI_TRANS_START_READ_WRITE] => 2
    [MYSQLI_TRANS_START_READ_ONLY] => 4
    [MYSQLI_TRANS_COR_AND_CHAIN] => 1
    [MYSQLI_TRANS_COR_AND_NO_CHAIN] => 2
    [MYSQLI_TRANS_COR_RELEASE] => 4
    [MYSQLI_TRANS_COR_NO_RELEASE] => 8
)

[narfbg]

The use of constants instead of literal numbers is not the point, but ... look at the commit.

[Akshay-Hegde]

@narfbg Yeah I have seen it, thanks for the fix, it was just temporary solution for OP, as he wanted to escape bit datatype, I understand your point that modifying core is really not recommended.

[narfbg]

I've misread the docs and the patch was incorrect ... see #5276.

type is not a bigflags field (flags is)