From 560d05aac0687a22dd8c33554c6f205eac6fa112 Mon Sep 17 00:00:00 2001 From: Bytecoin Developer Date: Tue, 9 Oct 2018 18:07:41 +0300 Subject: [PATCH] Add the batch of release v3.3.2 commits --- ReleaseNotes.md | 4 ++++ src/Core/TransactionBuilder.cpp | 2 +- src/version.hpp | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ReleaseNotes.md b/ReleaseNotes.md index 5a8480f4..921489ec 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -1,5 +1,9 @@ ## Release Notes +### v3.3.2 + +- Fixed bug when an invalid transaction may persist in the payment queue. + ### v3.3.1 - The `create_transaction` method can now create transactions with fee < 0.01 BCN iff both `fee_per_byte` and transaction size are small enough. diff --git a/src/Core/TransactionBuilder.cpp b/src/Core/TransactionBuilder.cpp index eddf38f0..a1227c7a 100644 --- a/src/Core/TransactionBuilder.cpp +++ b/src/Core/TransactionBuilder.cpp @@ -522,7 +522,7 @@ bool UnspentSelector::select_optimal_outputs(HaveCoins *have_coins, DustCoins *d select_max_outputs(have_coins, dust_coins, total_amount, anonymity, std::numeric_limits::max()); if (small_optimizations) optimize_amounts(have_coins, max_digit, total_amount); - return true; + return m_used_total >= total_amount; } void UnspentSelector::select_max_outputs( diff --git a/src/version.hpp b/src/version.hpp index 3efafe0b..af79c926 100644 --- a/src/version.hpp +++ b/src/version.hpp @@ -4,8 +4,8 @@ #pragma once // defines are for Windows resource compiler -#define bytecoin_VERSION_WINDOWS_COMMA 3, 18, 10, 3 -#define bytecoin_VERSION_STRING "3.3.1" +#define bytecoin_VERSION_WINDOWS_COMMA 3, 18, 10, 9 +#define bytecoin_VERSION_STRING "3.3.2" #ifndef RC_INVOKED // Windows resource compiler