Fix undefined meta transaction type for SCW #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration
Integration to master - remove web3
Integration
livingrock7
reviewed
Feb 25, 2021
|
Changed to integration branch. By the way, I'm not certain where the difference in build comes from, but I suspect it's node version. If you add an |
artsparkAI
changed the title
|
I was incorrect in my assumption, |
livingrock7
reviewed
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #67
Biconomy sdk inits fine after this check
It seems that wherever
smartContractMetaTransactionMapis used for SCW it has an address fromapi, so moving it inside the branch seems fine.Built files NOT included here because my particular node version was causing a huge diff in dist/mexa.js, someone on the team will have to build probably.