Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions managers for macOS/Linux #30

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@alonalon
Copy link
Contributor

commented Apr 9, 2019

Add two options to manage multiple node versions for macOS & Linux

馃帀 Thanks for sending this pull request! 馃帀

Please make sure:

Add versions managers for macOS/Linux
Add two options to manage multiple node versions for macOS & Linux
@ehmicky
Copy link
Collaborator

left a comment

Thanks a lot for this PR!

Few details:

  • Could you please put them right after nvm-windows?
  • Could you use the same description for both? They basically do the same thing, although their GitHub repository description is slightly different.
  • Could you decapitalize words (except Node)?
  • Periods at end of the sentence, to match the rest of the list.

@alonalon alonalon force-pushed the alonalon:master branch from 70d7119 to 4a451c5 Apr 9, 2019

Update to match rest of list
- Put new items after nvm
- Use same description
- Decapitalize some words (kept Linux as capitalized to match rest of list)
- End with period

@alonalon alonalon force-pushed the alonalon:master branch from 4a451c5 to cbce2a4 Apr 9, 2019

@alonalon

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

Should be fixed now :)

@ehmicky ehmicky merged commit a26d4fb into bcoe:master Apr 9, 2019

@ehmicky

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

Thanks @alonalon!

I will add you to our list of contributors tomorrow (I have no laptop access right now).

@ehmicky

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.