-
Notifications
You must be signed in to change notification settings - Fork 8
Save dependencies. Fixes #12 #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
|
OK, I fixed the build. Done playing with it. :) |
|
@hildjj this is looking awesome! appreciate the huge amount of work. One immediate comment, mind updating the README with some of the new features you've added, this will aid me in my code review. |
|
On it. |
|
Note: I'm also willing to migrate the existing tests to use the tempdir approach, so that the tests don't modify the node_modules directory of this package -- which would be cleaner. |
|
Sorry for the noise. I'm finding stuff as I start to use the new features in another project. Let me know if you want me to consolidate down to a single patch. |
|
See https://github.com/hildjj/node-cbor/blob/optional/package.json for a working example of how I intend this to be used. |
|
Status? I'm about to put this into production for node-cbor, and I'd much rather point to a normal dependency than to my github repo. |
|
@hildjj sorry about the slow turn around. I've published I've also added you as an owner to |
|
Thanks! |
Sorry for the large-ish PR, but this is functionality that needed to all go together.
new capabilities:
I also fixed a major bug. The existing code tended to check for dependencies in the node_modules of this module, rather than the one in which it was executing.
This should be backward-compatible both on the command line as well as the API, so you could do a minor version bump if you liked.