New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We just made the first BCoin block: 457010 #160

Closed
bitkevin opened this Issue Mar 13, 2017 · 4 comments

Comments

Projects
None yet
5 participants
@D3V4N5H

This comment has been minimized.

Copy link

D3V4N5H commented Mar 13, 2017

@SwimmingTiger

This comment has been minimized.

Copy link

SwimmingTiger commented Mar 13, 2017

It's cool but not flawless. Because of #159 and the other compatibility issue from BTC pool and bcoin, I have to write a PHP script to wrap the JSON-RPC calls to bcoin.

It's the script: bcoin-rpc-proxy.php

It solves two issues: #159 and the other:

BCoin dosen't update the curtime when getblocktemplate calls until a new transaction into it's mempool.

@MaxLyons

This comment has been minimized.

Copy link

MaxLyons commented Mar 13, 2017

can someone explain what this is please? thx haha

@chjj

This comment has been minimized.

Copy link
Member

chjj commented Mar 13, 2017

@SwimmingTiger Sorry to hear you had to write a wrapper. A fix for #159 is on master now. The curtime issue should be resolved when I merge in the current branch I'm working on (plugin-refactor), which refactors and improves a lot of the mining code. If that branch takes longer than I thought to stabilize, I'll probably just do another release with the current master which includes these fixes.

In any case, awesome work! Up until now, bcoin in production usually just meant the chain, mempool, and wallet code. Excited to see that the mining code is finally getting some battle testing.

chjj added a commit that referenced this issue Mar 13, 2017

chjj added a commit that referenced this issue Mar 14, 2017

@chjj chjj closed this May 12, 2017

@bcoin-org bcoin-org deleted a comment from D3V4N5H Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment