Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create client module from bclient #838

Merged
merged 1 commit into from Sep 13, 2019
Merged

Create client module from bclient #838

merged 1 commit into from Sep 13, 2019

Conversation

@braydonf
Copy link
Contributor

@braydonf braydonf commented Sep 6, 2019

Closes #834

@codecov-io

This comment has been hidden.

@tynes
Copy link
Member

@tynes tynes commented Sep 6, 2019

NACK until there is a clear upgrade path for users of just bclient itself. @BluSyn thoughts?

This change will blow up the size of the bundle for anybody that wants just the client since bcoin doesn't support es modules (with tree shaking) yet.

@braydonf
Copy link
Contributor Author

@braydonf braydonf commented Sep 7, 2019

@tynes This adds the client to bcoin so that it can move with tightly coupled parts within wallet. I would imagine other applications, similar to wallet, that depend on bclient would have a similar need and would do something similar. However, this is not removing bclient, which can still continue to be used, as well as bcurl.

@tynes
Copy link
Member

@tynes tynes commented Sep 9, 2019

ACK on the agreement that any changes to the bclient codebase that is brought into bcoin will be done in a way that makes it easy to backport the changes to the bclient package. This will prevent users of bclient from falling out of compatibility.

Its likely there won't be a ton of changes over time, so this should be manageable to do.

braydonf added a commit that referenced this issue Sep 13, 2019
Create client module from bclient
@braydonf braydonf merged commit f79224f into bcoin-org:master Sep 13, 2019
3 checks passed
@braydonf braydonf deleted the client branch Sep 13, 2019
@braydonf braydonf added this to the 2.0.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants