Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip url encoding for OAuth->uri() #268

Open
bucs-fan813 opened this issue Jan 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@bucs-fan813
Copy link
Contributor

commented Jan 13, 2019

Some OAuth endpoints (like stackoverflow) do not like the parameters passed with URL encoding. since OAuth->uri() uses http_build_query(), all URIs generated will have invalid characters. This specifically affects access_token and key parameters.

bucs-fan813 added a commit to bucs-fan813/fatfree-core that referenced this issue Jan 13, 2019

bucs-fan813 added a commit to bucs-fan813/fatfree-core that referenced this issue Jan 13, 2019

@KOTRET

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

Maybe use http_build_query's enc_type = PHP_QUERY_RFC3986 for that purpose (only escape spaces) and set this as instance var, because the request-method uses http_build_query too?
Sidenote: please clean up your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.