Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .desktop file #162

Open
FSMaxB opened this issue Feb 21, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@FSMaxB
Copy link

commented Feb 21, 2018

It would be great to add a .desktop file by default when installing the GUI version. Look here for an example.

This would also require installing an icon to /usr/share/pixmaps. Preferably U.svg.

@bcpierce00

This comment has been minimized.

Copy link
Owner

commented Feb 21, 2018

Happy to consider a PR.

@FSMaxB

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

I don't understand how make install works for unison to be honest. Usually there is DESTDIR that can be set for installation directory. But unison doesn't seem to do that. It uses "$(HOME)" instead.

Maybe that should be fixed first. (DESTDIR could be set to $(HOME) by default to preserve the existing behavior.

@bcpierce00

This comment has been minimized.

Copy link
Owner

commented Feb 21, 2018

I don't think that many people use "make install," other than me. :-|

Your proposed refinement sounds good.

@FSMaxB

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

Actually I gave up for now. This is more complicated than I expected.

@FSMaxB

This comment has been minimized.

Copy link
Author

commented Feb 21, 2018

It would be easier if:

  • unison would build executables with different names for different UISTYLE. e.g. unison-text unison-gtk2
  • there was a way to know what has been built when running make install, which could just be the filenames from the build step
  • unison wouldn't try to build the code again when running make install
@bcpierce00

This comment has been minimized.

Copy link
Owner

commented Feb 22, 2018

These also seem like reasonable refinements. One could retain backward compatibility by copying the latest-built binary (unison-text or whatever) to 'unison'.

The reason we never did something like this is that there are actually just three UI configurations (text, GTK, and the OSX native one); of these, the build and install procedure for the third is separate from the other two, while the GTK configuration supersedes the text one (i.e., it can be used in both ways).

@Vladimir-csp

This comment has been minimized.

Copy link

commented Jan 25, 2019

The one from Debian is better IMHO, it properly utilizes GenericName, although needs version string removed or scripted:

[Desktop Entry]
Name=Unison
Comment=GTK interface for the unison file synchronization tool 2.48.4
GenericName=File synchronization tool
Exec=unison-2.48.4-gtk
Terminal=false
X-MultipleArgs=false
Type=Application
Icon=unison-gtk.svg
Categories=Utility;FileTools;GTK;
StartupWMClass=Unison-gtk
StartupNotify=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.