Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake 4.x #3

Merged
merged 3 commits into from Dec 30, 2019
Merged

Cake 4.x #3

merged 3 commits into from Dec 30, 2019

Conversation

@challgren
Copy link

challgren commented Dec 3, 2019

Adds support for CakePHP 4.x. I can't create a new branch but it would be best to merge this into cake-4.x

challgren added 3 commits Dec 3, 2019
Signed-off-by: Chris Hallgren <challgren@gmail.com>
Signed-off-by: Chris Hallgren <challgren@gmail.com>
Signed-off-by: Chris Hallgren <challgren@gmail.com>
@bcrowe bcrowe changed the base branch from master to cake-4.x Dec 30, 2019
@bcrowe

This comment has been minimized.

Copy link
Owner

bcrowe commented Dec 30, 2019

Oh wow, sorry just noticing this now! I created a cake-4.x branch like you suggested and changed the base branch for this PR. I'll get this merged in for now, let me look into making a release?

@bcrowe bcrowe merged commit 905b110 into bcrowe:cake-4.x Dec 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@challgren

This comment has been minimized.

Copy link
Author

challgren commented Dec 30, 2019

Yeah if you want to release 2.0.0-beta that would be awesome. Since this is so simple of an implementation and all the tests are passing I'd say you could do 2.0.0 stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.