Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD 12 support #166

Closed
wants to merge 7 commits into from
Closed

FreeBSD 12 support #166

wants to merge 7 commits into from

Conversation

@kirillrdy
Copy link

@kirillrdy kirillrdy commented Apr 14, 2018

this is similar to @joegsn approach from #150 but also ensures FreeBSD 11 and most importantly OSX are not broken

@kirillrdy
Copy link
Author

@kirillrdy kirillrdy commented Apr 14, 2018

hmm, doesn't actually work ... need more testing

@kirillrdy
Copy link
Author

@kirillrdy kirillrdy commented Apr 17, 2018

@sparkymat give it a test. Should be all good now

@courtland
Copy link

@courtland courtland commented Jun 12, 2018

I'm also interested in this patch or some form of it making its way into the official gem. For now I have accepted this pull request into my own fork. It works for my environment under macOS, FreeBSD-10.1-RELEASE, FreeBSD-11.1-RELEASE, and FreeBSD-12.0-CURRENT.

FreeBSD 12 is indeed not slated to come out until late October / early November 2018, but in my case I have a rails app that must be vetted against FreeBSD-CURRENT in time for its release and bcrypt compilation is one of the road blocks.

It looks like FreeBSD has already adopted some form of this patch in the ports tree.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

@kirillrdy kirillrdy force-pushed the kirillrdy:master branch from fac03b7 to 63f6088 Dec 3, 2018
@kirillrdy
Copy link
Author

@kirillrdy kirillrdy commented Dec 3, 2018

I've rebased against latest master and applied patches similar to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

Let me know what you guys think

@tjschuck
Copy link
Collaborator

@tjschuck tjschuck commented Dec 3, 2018

Both of your final changes are in the vendored C implementation that this library uses — please propose them upstream at https://www.openwall.com/crypt/, and then they can be pulled downstream into bcrypt-ruby.

Thanks!

@tjschuck tjschuck closed this Dec 3, 2018
@solardiz
Copy link

@solardiz solardiz commented Dec 12, 2018

Someone posted this PR's URL as a "Quick Comment" at https://www.openwall.com/crypt/ so I just took a look. To me, the weirdest thing is that you're apparently trying to use this wrapper code intended for use inside a libc in a project that isn't a libc. That's why you're running into issues. Perhaps you should be using crypt_blowfish's native interfaces and not the wrappers.

@tymat
Copy link

@tymat tymat commented May 1, 2019

This has not been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants