Viewer: default datadir to /tmp, show url #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@lorin
Contributor

lorin commented Aug 31, 2012

Two changes to viewer:

  • Change the default datadir to /tmp. This makes it symmetric
    with using "-m plop.collector", which puts data in /tmp.

Print out the URL when the viewer runs, in case the user has
forgotten what port it's running on.

Viewer: default datadir to /tmp, show url
Two changes to viewer:

- Change the default datadir to /tmp. This makes it symmetric
with using "-m plop.collector", which puts data in /tmp.

Print out the URL when the viewer runs, in case the user has
forgotten what port it's running on.
@bdarnell

This comment has been minimized.

Show comment Hide comment
@bdarnell

bdarnell Aug 31, 2012

Owner

/tmp tends to be pretty messy, so I'm not sure it's a good idea to default to that (and if we wanted symmetry with the command-line plop.collector we could go further and hard-code /tmp/plop.out). I think it'd be better to move away from /tmp entirely - maybe make a directory for it and write the profiles to $HOME/plop/$ARGV0-$TIMESTAMP.plop.

Owner

bdarnell commented Aug 31, 2012

/tmp tends to be pretty messy, so I'm not sure it's a good idea to default to that (and if we wanted symmetry with the command-line plop.collector we could go further and hard-code /tmp/plop.out). I think it'd be better to move away from /tmp entirely - maybe make a directory for it and write the profiles to $HOME/plop/$ARGV0-$TIMESTAMP.plop.

@lorin

This comment has been minimized.

Show comment Hide comment
@lorin

lorin Aug 31, 2012

Contributor

As long as there's a sensible default that's consistent across "-m plop.collector" and "-m plop.viewer", I'd be happy.

What about using the current directory as the default location for writing the profiles? That's what I would have expected it to do.

Contributor

lorin commented Aug 31, 2012

As long as there's a sensible default that's consistent across "-m plop.collector" and "-m plop.viewer", I'd be happy.

What about using the current directory as the default location for writing the profiles? That's what I would have expected it to do.

@ralphleon

This comment has been minimized.

Show comment Hide comment
@ralphleon

ralphleon Oct 23, 2012

I just got hit by this too as a new user. I think that the /tmp default write location makes little sense and that the github instructions are pretty much wrong for a user getting started. Especially because I no have "demo/profiles".

Both defaulting to the CWD seems way more sane to me.

I just got hit by this too as a new user. I think that the /tmp default write location makes little sense and that the github instructions are pretty much wrong for a user getting started. Especially because I no have "demo/profiles".

Both defaulting to the CWD seems way more sane to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment