Skip to content

Ben Darnell bdarnell

  • Joined on Dec 01, 2009

Organizations

Ben Darnell
Invalid XSRF cookie value throws TypeError
Ben Darnell
Ben Darnell
bdarnell closed pull request tornadoweb/tornado#1097
Ben Darnell
Handle bogus values passed to `_xsrf`
bdarnell commented on pull request tornadoweb/tornado#1097
Ben Darnell

Cool. I'm going to merge this into master, where it can go into 4.0b3 tonight (and 4.0 final in a week or so). I'm open to doing a 3.2.3 with this,…

Ben Darnell
  • Ben Darnell ae6d76f
    Install make(1) when provisioning the vagrant VM.
bdarnell commented on pull request tornadoweb/tornado#1097
Ben Darnell

This fails on Python 3 (see the travis logs) - it raises binascii.Error instead of TypeError.

Ben Darnell
bdarnell commented on pull request tornadoweb/tornado#1097
Ben Darnell

Both of these are failure tests, not success tests (at least with the behavior in this commit; I'm thinking that it would be better if we allowed s…

bdarnell commented on pull request tornadoweb/tornado#1098
Ben Darnell

The middleware I'm suggesting would sit between WSGIContainer and your django app and set the SCRIPT_NAME field before passing the environment alon…

bdarnell commented on pull request tornadoweb/tornado#1097
Ben Darnell

Would it work to simply say token = utf8(cookie) in this case?

bdarnell commented on pull request tornadoweb/tornado#1098
Ben Darnell

I'm confused. Nginx isn't running tornado, so how is it setting environment variables that are relevant here? Couldn't this be done with WSGI midd…

bdarnell commented on pull request tornadoweb/tornado#1097
Ben Darnell

I used to recommend setting _xsrf to an arbitrary constant for testing and non-browser clients, which would run into this a lot. I wonder if we sho…

Ben Darnell
  • a795545
    Implement enough of hpack to pass the tests in appendix D.2.
Ben Darnell
bdarnell created repository bdarnell/tornado_http2
Ben Darnell
  • Ben Darnell 9788e4f
    Fix outdated variable name in docs.
Ben Darnell
  • Ben Darnell 6a58814
    Add a test for exception in websocket callbacks.
Ben Darnell
  • Ben Darnell 2fdfcb1
    Rewrite chatdemo to use a coroutine instead of callbacks.
bdarnell deleted branch guide at tornadoweb/tornado
Ben Darnell
bdarnell created branch guide at tornadoweb/tornado
bdarnell commented on issue tornadoweb/tornado#1094
Ben Darnell

That's a good point. The reason for the current behavior is that I've always looked at this from the opposite perspective: a few headers (notably S…

bdarnell commented on pull request tornadoweb/tornado#1092
Ben Darnell

This needs tests to ensure it is doing the right thing. Be sure to test with both chunked and non-chunked responses. apply() is no longer present …

Ben Darnell
bdarnell commented on issue tornadoweb/tornado#837
Ben Darnell

The default_handler_class setting was added in Tornado 3.2 to address this issue.

Ben Darnell
Allow the tornado.web.Application to use a custom error handler
Ben Darnell
Ben Darnell
Something went wrong with that request. Please try again.