Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoH classes display incomplete skill lists #22

Closed
klintworthde opened this issue Jun 1, 2020 · 1 comment
Closed

DoH classes display incomplete skill lists #22

klintworthde opened this issue Jun 1, 2020 · 1 comment

Comments

@klintworthde
Copy link

By my count, all crafting classes essentially have the same 34 skills (although one is only for Specialists and several have different icons). The planner currently only shows ten skills for all DoH classes.

The ten you choose seem to all share icons; however, not all cross-class skills still appear. For one, Name of the Elements displays while Brand of the Elements does not.

As a quick query of the database you're drawing from, a la

search?filters=ClassJob.ID=10&string=

seems to show all of the skills, something must be going wrong with fetching them.

@bdejesus
Copy link
Owner

Thanks for reporting! The initial implementation was a bit hacky, just so I could get most of the actions up. I finally found some time to revisit this and clean up the API requests and should now be returning the complete actions list for all classes.

7f71f60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants