New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call 'minetest.global_exists' to check for 'intllib' mod #5
Conversation
init.lua
Outdated
local S | ||
if intllib then | ||
if have_intl then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply if minetest.global_exists("intllib") then
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I suppose that is smarter since it is only called once.
I'm fairly new to pull requests on GitHub. Is creating a new commit, like I did, okay? Or is it better to reset & overwrite branch so that unaccepted commits are not in history? Or will that mess up the pull request? |
If you adjust your changes, you can run |
Okay, I'm understanding now. If I amend & force overwrite the remote branch it won't affect the PR because it is in relation to the branch, not the commit itself. |
Yes, for pull requests you likely often need to force-push. |
Thanks again for the advice @HybridDog. |
Thanks @AntumDeluge. Much appreciated. |
Fixes 'Undeclared global variable "intllib"'.