Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call 'minetest.global_exists' to check for 'intllib' mod #5

Merged
merged 1 commit into from May 17, 2017

Conversation

AntumDeluge
Copy link
Contributor

Fixes 'Undeclared global variable "intllib"'.

init.lua Outdated
local S
if intllib then
if have_intl then
Copy link
Contributor

@HybridDog HybridDog May 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply if minetest.global_exists("intllib") then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I suppose that is smarter since it is only called once.

@AntumDeluge
Copy link
Contributor Author

AntumDeluge commented May 13, 2017

I'm fairly new to pull requests on GitHub. Is creating a new commit, like I did, okay? Or is it better to reset & overwrite branch so that unaccepted commits are not in history? Or will that mess up the pull request?

@HybridDog
Copy link
Contributor

HybridDog commented May 14, 2017

If you adjust your changes, you can run git add -A && git commit --amend; with the amend flag it doesn't add a new commit but changes the last one.
If you make different changes and for any reason don't want to open another PR, you can add another commit.
If you want to reorder commits or put some together, run git rebase -i and squash, move, rename, etc.

@AntumDeluge
Copy link
Contributor Author

Okay, I'm understanding now. If I amend & force overwrite the remote branch it won't affect the PR because it is in relation to the branch, not the commit itself.

@HybridDog
Copy link
Contributor

Yes, for pull requests you likely often need to force-push.
However, if the PR is closed, you can't reopen it after force-pushing (my experience ;¬).

@AntumDeluge
Copy link
Contributor Author

Thanks again for the advice @HybridDog.

@bdjnk bdjnk merged commit 78d0166 into bdjnk:master May 17, 2017
@bdjnk
Copy link
Owner

bdjnk commented May 17, 2017

Thanks @AntumDeluge. Much appreciated.

@AntumDeluge AntumDeluge deleted the fixes branch June 6, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants