Skip to content

Conversation

@haberdashPI
Copy link
Member

@haberdashPI haberdashPI requested a review from kolia July 15, 2022 14:09
Copy link

@kolia kolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #16 (f8be94e) into main (3359c33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files           1        1           
  Lines         162      162           
=======================================
  Hits          145      145           
  Misses         17       17           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@haberdashPI
Copy link
Member Author

haberdashPI commented Jul 15, 2022

I'm going to leave this open to give the authors of each package a chance to respond with any feedback (I posted about this PR in the thread referenced in the OP).

@haberdashPI haberdashPI merged commit 515e55a into main Jul 18, 2022
@haberdashPI haberdashPI deleted the dfl/related-packages branch July 18, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants