Skip to content

Conversation

@ericphanson
Copy link
Member

A one-liner to allow MsgPack (de)serialization of TimeSpan's.

@ericphanson ericphanson requested a review from jrevels May 28, 2020 12:59
@ericphanson
Copy link
Member Author

Huh, the flac test failure is odd; it passes locally on 1.4.1.

@jrevels
Copy link
Member

jrevels commented May 28, 2020

Huh, the flac test failure is odd; it passes locally on 1.4.1.

Yeah, it's clearly unrelated...just restarted CI to see if it passes

@ericphanson
Copy link
Member Author

Ok great, tests are passing. Should I bump the version here as well?

@hannahilea
Copy link
Contributor

Ok great, tests are passing. Should I bump the version here as well?

Yep!

@jrevels jrevels merged commit 8e37d54 into master May 28, 2020
@jrevels jrevels deleted the eph/msgpack-timespan branch May 28, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants