Skip to content
Permalink
Browse files

of: overlay: remove sysfs_create_groups call

This crashes the kernel when an runtime overlay is applied.
  • Loading branch information...
stashlukj authored and RobertCNelson committed Nov 12, 2018
1 parent ad90715 commit e4853040647ff0c5c6658950a20646631e9422ad
Showing with 0 additions and 9 deletions.
  1. +0 −9 drivers/of/overlay.c
@@ -828,13 +828,6 @@ static int __of_overlay_create(struct device_node *tree,
if (err)
goto err_revert_overlay;

err = sysfs_create_groups(&ov->kobj, ov->attr_groups);
if (err != 0) {
pr_err("%s: sysfs_create_groups() failed for tree@%s\n",
__func__, tree->full_name);
goto err_remove_kobj;
}

ov->kobj.kset = ov_kset;
err = kobject_add(&ov->kobj, NULL, "%d", id);
if (err != 0) {
@@ -852,8 +845,6 @@ static int __of_overlay_create(struct device_node *tree,

return id;

err_remove_kobj:
kobject_put(&ov->kobj);
err_cancel_overlay:
of_changeset_revert(&ov->cset);
err_revert_overlay:

0 comments on commit e485304

Please sign in to comment.
You can’t perform that action at this time.