Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large ArrayBuffers (~20MB) passed through RPC crash Beaker #22

Open
kickscondor opened this issue Jun 29, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@kickscondor
Copy link
Contributor

commented Jun 29, 2019

Hi, I've been working on a mixtape-sharing site that runs on Beaker (duxtape.kickscondor.com) and generally it works quite well. So, thank you!

There are issues, however, with large files that are added to the mixtape. I have tried to get familiar with Beaker's code before reporting this - but there is a lot going on! My stack trace seems to show that the crash happens in pauls-electron-rpc - at valueToIPCValue. It's an out of memory error.

Uploading large files through the Beaker library doesn't exhibit this problem: that page uses the internal importFromFilesystem call.

Options:

  • Expose something similar to importFromFilesystem but which can work with the browser's File or Blob API. Could this be done securely?
  • Stream data through RPC - I started looking at adding this, but it will take me some time to understand the RPC layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.