Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating the Header object for globalFetch's RPC call. #25

Merged

Conversation

@kickscondor
Copy link
Contributor

commented Jul 11, 2019

So - sending headers over globalFetch doesn't actually work. In fg, the headers are a Fetch API Headers object. These don't make it through RPC - perhaps because bg doesn't have the Headers class. Whatever the case - this code builds a vanilla Object that gets passed.

This also handles 204 and 304 status codes (which are null body status codes). This work is to allow me to cache data in an RSS reader-type Dat app.

Cool - lots of love.

  • kicks
@pfrazee

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

👍 Super, thanks so much!

@pfrazee pfrazee merged commit c4198e3 into beakerbrowser:master Jul 12, 2019

@kickscondor kickscondor deleted the kickscondor:electron5-fetch-headers-fix branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.