New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-install building to plugins #59

Closed
pfrazee opened this Issue Aug 16, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@pfrazee
Member

pfrazee commented Aug 16, 2016

The native modules in the plugins have to be rebuilt for the current Electron version, due to some ABI hijinks. This needs to happen automatically, now, after install or update, to work with Beaker's plugin installer.

@pfrazee pfrazee added the enhancement label Aug 16, 2016

@pfrazee pfrazee added this to the v0.2.0 milestone Aug 16, 2016

@pfrazee pfrazee changed the title from Add rebuild post-install step to dat plugin to Add post-install building to plugins Aug 20, 2016

@pfrazee

This comment has been minimized.

Member

pfrazee commented Aug 20, 2016

There's an upstream bug that makes dat (the plugin that currently needs this) hard to work on: mafintosh/utp-native#7

@pfrazee

This comment has been minimized.

Member

pfrazee commented Aug 23, 2016

I was discovering a lot of difficult edge-cases in the in-browser plugin installer, which made me worry that, without proper infrastructure to support this complex of a feature, the product would be be buggy. Building Electron for multiple platforms is already pretty difficult; making a more complex packaging system, like this, would be much worse.

The feedback I've received from other protocol designers is somewhat split. While I think some protocol devs would strongly appreciate having the in-browser plugin installer, there are others who are more likely to need a custom packaging or fork of beaker. Therefore, since protocol engineers are, ultimately, a minority of Beaker's intended users, and, among them, the need for an installer is divided, I've decided not to make this a priority.

Docs have been updated to reflect the new solution: plugins are installed locally, and Beaker must be rebuilt from source to enable them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment