New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues setting up beaker dev env #856

Closed
zeke opened this Issue Feb 18, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@zeke
Contributor

zeke commented Feb 18, 2018

Operation System: macOS
Beaker Version: master branch

I have a fresh clone of this repo. I ran npm install && npm start and saw this:

screen shot 2018-02-17 at 6 28 23 pm

So I ran npm run build, then saw this:

screen shot 2018-02-17 at 6 28 52 pm

Then I ran cd app && npm install && cd .. Same errors from start and build scripts.

Then npm run rebuild && npm run start and now I'm good.

So... let's document the right incantation in CONTRIBUTING.md. Does the following represent the current reality?

git clone https://github.com/beakerbrowser/beaker
cd beaker
npm install
npm run build
npm run rebuild
npm start
@pfrazee

This comment has been minimized.

Member

pfrazee commented Feb 18, 2018

@zeke

This comment has been minimized.

Contributor

zeke commented Feb 18, 2018

we have a “building from source” section in the readme

Ah oops I jumped straight to the existing CONTRIBUTING.md and didn't bother looking in the README.

I see a few paths forward:

  • Move the dev setup instrucutions from README to CONTRIBUTING, and add a link to the README

or

  • Leave instructions where they are, and link to them from CONTRIBUTING

@pfrazee pfrazee closed this in 7e2a237 Feb 19, 2018

@pfrazee

This comment has been minimized.

Member

pfrazee commented Feb 19, 2018

Ok should be much clearer now. Thanks!

@zeke

This comment has been minimized.

Contributor

zeke commented Feb 19, 2018

Bravo! Grazie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment