So it was a timing issue. Looks like the clone’s peers were not being populated (sometimes?… as I swear I saw it pass earlier) by the time the streams handshake event had fired. Running the tests on the next tick solved the issue. All tests passing again.
Please feel free to merge at your leisure unless you find any other issues. I’m happy with it :)
changed the title
WIP: Add hyperdb support and run tests for hypercore, hyperdb, and hyperdriveFeb 3, 2019
@aral Sounds good, I'll test it in Beaker. One other nit - you're using the variable name database as a catchall for different dat structures. That does makes sense, but I'd prefer to use dat instead. Would you mind changing it?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.