From 660964ce25938168d1e1641a5d647e32e2ad110a Mon Sep 17 00:00:00 2001 From: luke-lombardi <33990301+luke-lombardi@users.noreply.github.com> Date: Sat, 30 Nov 2024 13:50:09 -0500 Subject: [PATCH 1/3] more debug logs --- pkg/discovery.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/discovery.go b/pkg/discovery.go index cffcee8..3d0d492 100644 --- a/pkg/discovery.go +++ b/pkg/discovery.go @@ -151,6 +151,7 @@ func (d *DiscoveryClient) discoverHostsViaMetadata(ctx context.Context) ([]*Blob hostState, err := d.GetHostStateViaMetadata(ctx, addr, host.PrivateAddr) if err != nil { + Logger.Debugf("Failed to get host state: %v", err) return } @@ -254,6 +255,7 @@ func (d *DiscoveryClient) GetHostStateViaMetadata(ctx context.Context, addr, pri grpc.WithTransportCredentials(insecure.NewCredentials()), } + Logger.Debugf("Dialing host: %s", addr) dialCtx, cancel := context.WithTimeout(ctx, time.Duration(d.cfg.GRPCDialTimeoutS)*time.Second) defer cancel() From 3306e791bdf0d1abe5e1dc03a50258042a08fcc5 Mon Sep 17 00:00:00 2001 From: luke-lombardi <33990301+luke-lombardi@users.noreply.github.com> Date: Sat, 30 Nov 2024 13:59:41 -0500 Subject: [PATCH 2/3] use dial context --- pkg/discovery.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/discovery.go b/pkg/discovery.go index 3d0d492..45903d8 100644 --- a/pkg/discovery.go +++ b/pkg/discovery.go @@ -255,7 +255,9 @@ func (d *DiscoveryClient) GetHostStateViaMetadata(ctx context.Context, addr, pri grpc.WithTransportCredentials(insecure.NewCredentials()), } - Logger.Debugf("Dialing host: %s", addr) + // Log the timeout value for debugging + Logger.Debugf("Dial timeout set to: %d seconds", d.cfg.GRPCDialTimeoutS) + dialCtx, cancel := context.WithTimeout(ctx, time.Duration(d.cfg.GRPCDialTimeoutS)*time.Second) defer cancel() @@ -266,7 +268,8 @@ func (d *DiscoveryClient) GetHostStateViaMetadata(ctx context.Context, addr, pri defer conn.Close() c := proto.NewBlobCacheClient(conn) - resp, err := c.GetState(ctx, &proto.GetStateRequest{}) + + resp, err := c.GetState(dialCtx, &proto.GetStateRequest{}) if err != nil { return nil, err } From d729e5f3eb860ec69bdd082382c5a71b508c839d Mon Sep 17 00:00:00 2001 From: luke-lombardi <33990301+luke-lombardi@users.noreply.github.com> Date: Sat, 30 Nov 2024 14:06:46 -0500 Subject: [PATCH 3/3] remove logs --- pkg/discovery.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/discovery.go b/pkg/discovery.go index 45903d8..9519ccf 100644 --- a/pkg/discovery.go +++ b/pkg/discovery.go @@ -151,7 +151,6 @@ func (d *DiscoveryClient) discoverHostsViaMetadata(ctx context.Context) ([]*Blob hostState, err := d.GetHostStateViaMetadata(ctx, addr, host.PrivateAddr) if err != nil { - Logger.Debugf("Failed to get host state: %v", err) return } @@ -255,9 +254,6 @@ func (d *DiscoveryClient) GetHostStateViaMetadata(ctx context.Context, addr, pri grpc.WithTransportCredentials(insecure.NewCredentials()), } - // Log the timeout value for debugging - Logger.Debugf("Dial timeout set to: %d seconds", d.cfg.GRPCDialTimeoutS) - dialCtx, cancel := context.WithTimeout(ctx, time.Duration(d.cfg.GRPCDialTimeoutS)*time.Second) defer cancel()