From 212bef2161d3bc5da31efce9898a60b6555bf985 Mon Sep 17 00:00:00 2001
From: Stephen Bussey <sb8244@cs.ship.edu>
Date: Tue, 28 Nov 2023 11:28:57 -0500
Subject: [PATCH] Implement object_name_to_module so it will work for new
 objects in future (#792)

---
 lib/stripe/util.ex        | 48 ++++++++-------------------------------
 test/stripe/util_test.exs | 18 +++++++++++++++
 2 files changed, 28 insertions(+), 38 deletions(-)

diff --git a/lib/stripe/util.ex b/lib/stripe/util.ex
index 8343bb1b..2c596ba6 100644
--- a/lib/stripe/util.ex
+++ b/lib/stripe/util.ex
@@ -51,47 +51,19 @@ defmodule Stripe.Util do
   def atomize_key(k), do: k
 
   @spec object_name_to_module(String.t()) :: module
-  def object_name_to_module("billing_portal.configuration"),
-    do: Stripe.BillingPortal.Configuration
-
-  def object_name_to_module("billing_portal.session"), do: Stripe.BillingPortal.Session
-  def object_name_to_module("checkout.session"), do: Stripe.Checkout.Session
-  def object_name_to_module("radar.early_fraud_warning"), do: Stripe.Radar.EarlyFraudWarning
-  def object_name_to_module("file"), do: Stripe.File
-
-  def object_name_to_module("identity.verification_session"),
-    do: Stripe.Identity.VerificationSession
-
-  def object_name_to_module("identity.verification_report"),
-    do: Stripe.Identity.VerificationReport
-
-  def object_name_to_module("reporting.report_type"),
-    do: Stripe.Reporting.ReportType
-
-  def object_name_to_module("reporting.report_run"),
-    do: Stripe.Reporting.ReportRun
-
-  def object_name_to_module("issuing.authorization"), do: Stripe.Issuing.Authorization
-  def object_name_to_module("issuing.card"), do: Stripe.Issuing.Card
-  def object_name_to_module("issuing.cardholder"), do: Stripe.Issuing.Cardholder
-  def object_name_to_module("issuing.transaction"), do: Stripe.Issuing.Transaction
-  def object_name_to_module("tax_id"), do: Stripe.TaxId
-  def object_name_to_module("usage_record"), do: Stripe.UsageRecord
-  def object_name_to_module("terminal.connection_token"), do: Stripe.Terminal.ConnectionToken
-  def object_name_to_module("terminal.location"), do: Stripe.Terminal.Location
-  def object_name_to_module("terminal.reader"), do: Stripe.Terminal.Reader
-  def object_name_to_module("test_helpers.test_clock"), do: Stripe.TestHelpers.TestClock
-
-  def object_name_to_module("usage_record_summary"),
-    do: Stripe.UsageRecordSummary
+  def object_name_to_module("test_helpers.test_clock"), do: Stripe.TestClock
 
   def object_name_to_module(object_name) do
-    module_name =
+    module_parts =
       object_name
-      |> String.split("_")
-      |> Enum.map_join("", &String.capitalize/1)
-
-    Module.concat(Stripe, module_name)
+      |> String.split(".")
+      |> Enum.map(fn part ->
+        part
+        |> String.split("_")
+        |> Enum.map_join("", &String.capitalize/1)
+      end)
+
+    Module.concat([Stripe | module_parts])
   end
 
   @spec module_to_string(module) :: String.t()
diff --git a/test/stripe/util_test.exs b/test/stripe/util_test.exs
index 9f6bb7b7..6a57b86b 100644
--- a/test/stripe/util_test.exs
+++ b/test/stripe/util_test.exs
@@ -34,6 +34,24 @@ defmodule Stripe.UtilTest do
       assert object_name_to_module("transfer") == Stripe.Transfer
       assert object_name_to_module("transfer_reversal") == Stripe.TransferReversal
       assert object_name_to_module("token") == Stripe.Token
+
+      assert object_name_to_module("billing_portal.session") == Stripe.BillingPortal.Session
+      assert object_name_to_module("checkout.session") == Stripe.Checkout.Session
+      assert object_name_to_module("identity.verification_report") == Stripe.Identity.VerificationReport
+      assert object_name_to_module("identity.verification_session") == Stripe.Identity.VerificationSession
+      assert object_name_to_module("issuing.authorization") == Stripe.Issuing.Authorization
+      assert object_name_to_module("issuing.card") == Stripe.Issuing.Card
+      assert object_name_to_module("issuing.cardholder") == Stripe.Issuing.Cardholder
+      assert object_name_to_module("issuing.transaction") == Stripe.Issuing.Transaction
+      assert object_name_to_module("radar.early_fraud_warning") == Stripe.Radar.EarlyFraudWarning
+      assert object_name_to_module("reporting.report_type") == Stripe.Reporting.ReportType
+      assert object_name_to_module("reporting.report_run") == Stripe.Reporting.ReportRun
+      assert object_name_to_module("tax_id") == Stripe.TaxId
+      assert object_name_to_module("terminal.reader") == Stripe.Terminal.Reader
+      assert object_name_to_module("terminal.location") == Stripe.Terminal.Location
+      assert object_name_to_module("terminal.connection_token") == Stripe.Terminal.ConnectionToken
+      assert object_name_to_module("usage_record") == Stripe.UsageRecord
+      assert object_name_to_module("usage_record_summary") == Stripe.UsageRecordSummary
     end
   end