Include stack in error proplist #77

Merged
merged 4 commits into from Nov 30, 2012

2 participants

@gleber

It does few other minor changes like adding ?is_v8 macro, adding Array:unpush/1 and Object:copy_properties_to/1

@yrashk
beam.js member

does copy_properties_to really belong there?

@gleber

It doesn't have to be there, but it is very useful :) I've replaced at least three instances of lists:foreach over Object:proplist doing Copy:set_value in beamjs with this one.

@yrashk
beam.js member

Can we move it to some "utility module"?

@gleber

In utility module it would not be as useful, but I get that copy_properties_to in object doesn't fit the way it works in JS. I'll move it

@gleber

Moved them to erlv8_utils

@yrashk yrashk merged commit 157a7db into beamjs:master Nov 30, 2012
@yrashk
beam.js member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment