Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fava option in accounts page #1118

Closed
wants to merge 1 commit into from

Conversation

prafullat
Copy link

@prafullat prafullat commented Jun 6, 2020

Now account page supports fava options such as

show-accounts-with-zero-balance
show-accounts-with-zero-transactions

Fixes #1116

Now account page supports fava options such as

show-accounts-with-zero-balance
show-accounts-with-zero-transactions
Copy link
Member

@yagebu yagebu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look quite right - it only checks if the account should be shown according to the total over all entries. I think it should instead check whether should_show is true for an account for all of the intervals.

@yagebu
Copy link
Member

yagebu commented Aug 12, 2020

Closing this stale PR. Just reopen it if you ever want to continue this :)

@yagebu yagebu closed this Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Filter, Balance/Changes screen should not show accounts which have zero value because of the filter
2 participants