fix account page date order - #2109
Merged
Merged
Conversation
Contributor
Author
|
Hey @yagebu, it's probably a serious regression, so I tend to think there is some urgency to fix it. Could you please take a quick look at this PR? |
|
I’m also experiencing the same issue by this regression too, so I’d appreciate it if this could be fixed soon. |
Member
|
Fixes #2113 |
yagebu
approved these changes
Oct 12, 2025
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2058, the journal returned from
/account_reportwas incorrectly reversed, and consequently the sort value for date was wrong in the template.This was a remnant from early iterations when the index was always derived from the order passed to the template. Later iteration changes it to explicitly pass the index when doing pagination, so non-paginated path was no longer affected, but the json path was not reverted accordingly.
This PR fixes the issue by making the two paths work more consistently through adding explicit index to account journal as well. This makes the journal template still always render in reverse chronological order but with the right date index passed in.
The diff of the snapshot is:
as you can see the sort value is now correct.