Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tidyverse from Imports #31

Closed
beanumber opened this Issue May 31, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@beanumber
Copy link
Owner

beanumber commented May 31, 2018

As of 2018-03-30, your package, mdsr, lists the tidyverse package in
either Depends,
Imports, or Suggests on CRAN.

Because the tidyverse is a set of packages designed for interactive data
analysis, this is, in short, a bad idea. The tidyverse package includes a
substantial number of direct and indirect dependencies (79 packages, as of this
writing), many of which are likely unnecessary for the purposes of your package.
Furthermore, the CRAN maintainers frown upon depending on it, which can cause
hassle for you down the line.

If you could please correct this by importing functions from, suggesting,
or depending on the tidyverse component packages you require at your nearest
convenience, it would be most appreciated.

Please let us know if you have any questions.

Thank you,

Hadley Wickham
c/o Mara Averick

@beanumber beanumber self-assigned this May 31, 2018

@beanumber beanumber changed the title remove Depends remove tidyverse from Depends May 31, 2018

@beanumber beanumber changed the title remove tidyverse from Depends remove tidyverse from Imports May 31, 2018

@beanumber

This comment has been minimized.

Copy link
Owner Author

beanumber commented May 31, 2018

The issue actually occurs here:

x <- tidyverse::tidyverse_conflicts()

That is, we are actually importing a function from tidyverse.

@beanumber beanumber closed this in 97bd0e3 Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.