BVAL-508 Second round with both alternatives #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test |
|
|
||
| Extractors for the specific tuple container and value type can be implemented. | ||
|
|
||
| TODO: should we differentiate single and plural? |
There was a problem hiding this comment.
I think it's good for the sake of perf - no Iterable allocation in the singular case.
|
Replacement for #20 |
emmanuelbernard
force-pushed
the
BVAL-508
branch
from
c0618a4
to
90cf69c
Compare
|
@emmanuelbernard I've sent PR emmanuelbernard#1 against your repo with an update to my alternative. Overall I think we can continue discussion based on yours, as you say the have converged more or less. The only difference being support for unknown generic containers in my proposal, but I think that's sufficiently covered in your one with the possibility for providing a custom extractor in such cases. |
|
@emmanuelbernard, any thought? Do you think we can merge it (with the changes I made and sent as PR against your repo)? |
|
Applied to production and converted to asciidoc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This second round offers improvement on the initial proposal (called proposal 1)
@ExtractedValueIt also includes Gunnar's proposal (proposal 2). Gunnar's proposal does not go into all of the nasty details though, so this round of review will need to pounce this aspect.