Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNew Direct Message endpoint needs to be implemented #587
Comments
This comment has been minimized.
This comment has been minimized.
webtweakers
commented
Sep 20, 2018
|
I'm having the same issue, found the same cause, was looking for the same reason... |
This comment has been minimized.
This comment has been minimized.
at0m1sk
commented
Sep 21, 2018
|
There is a pull request that seems to integrate new endpoint. Request is from Aug 2018. |
This comment has been minimized.
This comment has been minimized.
spacecab07
commented
Sep 26, 2018
|
Any idea on when this might get resolved? |
This comment has been minimized.
This comment has been minimized.
|
Yes the version in the pull request is working for us. There are breaking changes to the function though, which is forced by Twitter's changes in the new direct message endpoint. Probably the biggest change is that screen name is no longer supported as a parameter, so we need to call api.GetUser first to get the user id. |
This comment has been minimized.
This comment has been minimized.
ganmedia
commented
Sep 29, 2018
|
Any news about this? When will the pull request be integrated? |
This comment has been minimized.
This comment has been minimized.
|
i'll look at this now |
This comment has been minimized.
This comment has been minimized.
|
added everything and fixed up the tests, changed the docs a few hours ago
to the 4.0 dev branch. sorry, been out of commission lately :(
Jeremy Low
JeremyLow@gmail.com
…On Sat, Sep 29, 2018 at 5:37 PM Mike Taylor ***@***.***> wrote:
i'll look at this now
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#587 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEucDWtagR6WM3-VTyrImGfKGK0R3Lk6ks5uf-gzgaJpZM4WxZXS>
.
|
This comment has been minimized.
This comment has been minimized.
|
@jeremylow do you want me to merge this to the master and bump the version to 3.6 since it's fixing a broken twitter? |
This comment has been minimized.
This comment has been minimized.
|
I was thinking a major version bump, since we have to deprecate a bunch of
endpoints, but I can do 3.6 too. I'm not married to either option.
…On Sat, Sep 29, 2018 at 5:44 PM Mike Taylor ***@***.***> wrote:
@jeremylow <https://github.com/jeremylow> do you want me to merge this to
the master and bump the version to 3.6 since it's fixing a broken twitter?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#587 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEucDaidk8I6qyzMcIauAcZ9pca5l60Pks5uf-nFgaJpZM4WxZXS>
.
|
This comment has been minimized.
This comment has been minimized.
|
@jeremylow I think I can make the method signature stay the same to reduce the impact - if ok, i'll merge the PR and see if that fixes things |
This comment has been minimized.
This comment has been minimized.
|
I think I have it working and i've tagged a pre-release for v3.5 Can you all give this a go and see if it works - i'll hold off pushing this to PyPI until someone sanity checks it |
This comment has been minimized.
This comment has been minimized.
webtweakers
commented
Sep 30, 2018
|
Thanks for picking this up. I've checked the v3.5 release and now things work again, as expected! Looking good from my side. |
This comment has been minimized.
This comment has been minimized.
ganmedia
commented
Sep 30, 2018
|
Version 3.5 checked and everything working with no problems. |
This comment has been minimized.
This comment has been minimized.
|
Good to go from me! |
This comment has been minimized.
This comment has been minimized.
kennethdamica
commented
Oct 2, 2018
|
PostDirectMessage works for me now, but I'm still getting error 34 for GetDirectMessages and GetSentDirectMessages. Looks like these endpoints have been collapsed into "GET direct_messages/events/list". Is this supposed to work in 3.5? |
This comment has been minimized.
This comment has been minimized.
spacecab07
commented
Oct 4, 2018
|
Sorry if this is a noob question. So, i need the user_id of the recipient of the DM? |
This comment has been minimized.
This comment has been minimized.
|
@spacecab07 if you don’t supply it, the api will attempt to look up the user id from the screen name. |
This comment has been minimized.
This comment has been minimized.
spacecab07
commented
Oct 4, 2018
|
@jeremylow so should be ok to leave as 'user_id=None, screen_name=twitter_handle' ? |
This comment has been minimized.
This comment has been minimized.
webtweakers
commented
Oct 4, 2018
|
@spacecab07 Yes, I have already confirmed that this works well - also check the code change. The API needs to make an extra call to Twitter now, so it is probably wise to retrieve and store the user_id in your own application once and use that at every DM post. |
This comment has been minimized.
This comment has been minimized.
spacecab07
commented
Oct 4, 2018
|
@webtweakers ok, thanks . |
This comment has been minimized.
This comment has been minimized.
at0m1sk
commented
Oct 14, 2018
Same here, I am at 3.5 can't GET , error 34 for GetDM and GetSentDM |
This comment has been minimized.
This comment has been minimized.
MHlinux
commented
Oct 27, 2018
•
|
Have the same PostDirectMessage issue and still do not get it done But all other works fine like So what else do I have to do in addition for direct mesages ??? Update: |
This comment has been minimized.
This comment has been minimized.
LuccoJ
commented
Nov 2, 2018
|
Could this please be made a priority for pushing a release to Pypi? Currently, according to what I've been able to figure out, there is no Twitter wrapper in Pypi that actually supports direct messages. I assume there's a number of applications that are badly broken by this and not just mine. |
This comment has been minimized.
This comment has been minimized.
Artfulme
commented
Nov 2, 2018
|
Hi, backing up @LuccoJ on this one, you're just one signature way from releasing the working code to pypi. Don't want to be pushy either, I have much respect for all the work you guys put in to maintain the code, but I have been following this thread since its inception and working direct messages can't come soon enough. |
This comment has been minimized.
This comment has been minimized.
|
My apologies y'all; been a draining couple weeks. I thought the release had been uploaded to PyPI. I'll take care of it this weekend. |
This comment has been minimized.
This comment has been minimized.
|
3.5 is now on pypi. |
This comment has been minimized.
This comment has been minimized.
Artfulme
commented
Nov 3, 2018
|
Thanks! |
melikyuksel commentedSep 20, 2018
Twitter deprecated the old direct message endpoints on September 17, 2018 (3 days ago) after warning about it in July. (see this link: https://twittercommunity.com/t/details-and-what-to-expect-from-the-api-deprecations-this-week-on-august-16-2018/110746)
Does Python Twitter yet support the new endpoints for it? (https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/guides/direct-message-migration)
Using the PostDirectMessage function right now results in "Sorry, that page does not exist." error 34 from Twitter.