New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start on fix for Issue #363 #364

Merged
merged 2 commits into from Jul 11, 2016

Conversation

Projects
None yet
2 participants
@bear
Owner

bear commented Jul 11, 2016

first pass is to make the 401 handled cleaner and then look into why we are getting a 401 at all for Steams


This change is Reviewable

bear added some commits Jul 11, 2016

add explicity try/except for json decoding so we can capture Auth err…
…ors which Twitter oh so helpfully returns as HTML
@bear

This comment has been minimized.

Owner

bear commented Jul 11, 2016

Going to merge this as it's breaking current stream usage - fixes Issue #363

@bear bear merged commit 3a48104 into master Jul 11, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@bear bear deleted the Issue_363 branch Jul 11, 2016

@jeremylow

This comment has been minimized.

Collaborator

jeremylow commented on 6c41fac Oct 3, 2016

@bear Do you remember what was being fixed here or the source of the problem? I'm working on a problem where some old accounts got suspended and data=None is being passed to Status.NewFromJsonDict because (I think) the TwitterError is being caught by the last except (apparently). I'd like to get something in place to handle both situations, but with Github's interface I can't pin down what was going on here, just that it's the source of my issue.

This comment has been minimized.

Owner

bear replied Oct 3, 2016

IIRC we were trying to make this handle unknown errors except if it was from an un-authed request

I don't mind at all if we pull back the "catch all" except and start adding them back in as testing finds the edge cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment