New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Quicktime (.mov) media uploads. #372

Merged
merged 2 commits into from Jul 24, 2016

Conversation

Projects
None yet
3 participants
@BenjyWiener
Contributor

BenjyWiener commented Jul 24, 2016

This change is Reviewable

@@ -200,7 +200,8 @@ def parse_media_file(passed_media):
'image/gif',
'image/bmp',
'image/webp']
video_formats = ['video/mp4']
video_formats = ['video/mp4,

This comment has been minimized.

@jeremylow

jeremylow Jul 24, 2016

Collaborator

You're missing a closing quotation mark.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 24, 2016

Current coverage is 69.12% (diff: 100%)

Merging #372 into master will not change coverage

@@             master       #372   diff @@
==========================================
  Files             8          8          
  Lines          2018       2018          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1395       1395          
  Misses          623        623          
  Partials          0          0          

Powered by Codecov. Last update e97d4e0...d2e79ea

@jeremylow

This comment has been minimized.

Collaborator

jeremylow commented Jul 24, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit 99e0cff into bear:master Jul 24, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 1 file reviewed
Details
codecov/patch 100% of diff hit (target 69.12%)
Details
codecov/project 69.12% (+0.00%) compared to e97d4e0
Details
@jeremylow

This comment has been minimized.

Collaborator

jeremylow commented Jul 24, 2016

Thanks for the PR!

@BenjyWiener BenjyWiener deleted the BenjyWiener:patch-1 branch Jul 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment