New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweet_volume not being populated for Trend objects #375

Merged
merged 3 commits into from Jul 29, 2016

Conversation

Projects
None yet
3 participants
@jeremylow
Collaborator

jeremylow commented Jul 29, 2016

Description

Trend.volume data should be populated on object creation, but because the json data from Twitter is named tweet_volume, this isn't occurring. This changes the property name to be tweet_volume which conforms with Twitter's naming convention and allows the property to be populated straight from the json data.

Additionally, an @property has been added to the Trend object for backwards compatibility.

Related Issue

#374

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This change is Reviewable

jeremylow added some commits Jul 29, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Jul 29, 2016

Current coverage is 69.15% (diff: 100%)

Merging #375 into master will increase coverage by 0.03%

@@             master       #375   diff @@
==========================================
  Files             8          8          
  Lines          2018       2020     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1395       1397     +2   
  Misses          623        623          
  Partials          0          0          

Powered by Codecov. Last update 99e0cff...138ca2e

@bear

This comment has been minimized.

Owner

bear commented Jul 29, 2016

:lgtm:


Reviewed 3 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jeremylow jeremylow merged commit 2f222c7 into master Jul 29, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 4 files reviewed
Details
codecov/patch 100% of diff hit (target 69.12%)
Details
codecov/project 69.15% (+0.03%) compared to 99e0cff
Details
dependency-ci Dependencies checked
Details

@jeremylow jeremylow deleted the fix/issue374 branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment