New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calc_expected_status_length (issue 415) #416

Merged
merged 2 commits into from Nov 28, 2016

Conversation

Projects
None yet
2 participants
@jeremylow
Collaborator

jeremylow commented Nov 28, 2016

With changes in 3.2 to the URL_REGEX in twitter_utils.py, the calc_expected_status_length wasn't working properly with URLs that were in the middle of a tweet. This fixes that issue and adds tests on that function.

Closes #415


This change is Reviewable

jeremylow added some commits Nov 26, 2016

@bear

This comment has been minimized.

Owner

bear commented Nov 28, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bear bear merged commit b39075e into master Nov 28, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
code-review/reviewable 3 files reviewed
Details
codecov/patch 100% of diff hit (target 74.80%)
Details
dependency-ci Dependencies checked
Details

@bear bear deleted the fix/issue415 branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment