Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional   #127

Closed
TheAnarchyState opened this issue Sep 5, 2014 · 13 comments
Closed

Additional   #127

TheAnarchyState opened this issue Sep 5, 2014 · 13 comments
Assignees
@etcook
Labels
bug editor
Milestone
1.3

Comments

@TheAnarchyState
Copy link

Every time I switch between the Text and Visual View, additional   are added to my code at the end of a Content block, just before [/aesop_content].
@bearded-avenger
Copy link
Collaborator

Unfortunately there's no real good way to eliminate this other than manually deleting, and publishing.

That happens as a result of us forcing a line break in the content component. It was a fix for #101

TinyMCE is one hell of a restrictive environment, which is why you typically don't see plugins doing what we're doing.

@TheAnarchyState
Copy link
Author

Okay. Do you see this problem persisting then? On a long story, this could become quite a job to remove all the additional line breaks if it was ever required to move between Text and Visual.

@bearded-avenger
Copy link
Collaborator

I completely understand, but you have to understand we're under the limitations of TinyMCE. This "bug", fixed the [/aesop_content] running up against the first line break in the Content component. Maybe @etcook can perhaps explain it a bit better.

P.S - Completely open to pull-requests. ;)

@etcook
Copy link
Collaborator

etcook commented Sep 5, 2014

Hrm - let me think about how I can solve this.

@etcook etcook self-assigned this Sep 5, 2014
etcook added a commit that referenced this issue Sep 10, 2014
@etcook
Attempt at #127
4adf2ca
@bearded-avenger
Copy link
Collaborator

@TheAnarchyState want to give this most recent version a spin and let us know how you go about? at least in my initial first passes i don't get any more  

https://github.com/bearded-avenger/aesop-core/archive/dev.zip

@TheAnarchyState
Copy link
Author

Hi Nick. This is working great, good work! One thing I did notice though, if the text is preceded by "< p class="lead" >", which we are using for the first paragraph of every chapter, then one line space is added in before the text.

@etcook
Copy link
Collaborator

etcook commented Sep 11, 2014

Can you provide a video or screenshots clearly showing the issue?

@michaelbeil
Copy link
Contributor

vid would be great.

@TheAnarchyState
Copy link
Author

Check it out at http://recordit.co/mHpSeJRfEQ.

bearded-avenger pushed a commit that referenced this issue Sep 17, 2014
Squashed commit of the following:
21e54b3 
commit d948bea
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 17 07:20:06 2014 -0500

    arrive() to video component and main js array

commit e0c9f80
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 16 17:57:21 2014 -0500

    fix spacing

commit d4265b3
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 16 17:40:31 2014 -0500

    use DOM mutation observer w/ arrive

commit 0236e5c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Sep 16 15:08:21 2014 -0500

    description tweak

commit 0c3309a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 15 08:27:56 2014 -0500

    cursor:pointer hack for mobile safari

commit d707945
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 15 08:14:21 2014 -0500

    possible fix for #131

commit c3288f5
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 15:09:47 2014 -0500

    update copyright year fixes #124

commit dd5e7ca
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 15:06:58 2014 -0500

    activation message grammer tweak

    fixes #112

commit 269d7b0
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 15:04:17 2014 -0500

    help link fixes #108

commit 2213eab
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 14:57:55 2014 -0500

    <code>style tweaks

    closes #119

commit b8ff064
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 13:11:51 2014 -0500

    even out padding on buttoninsert

commit 9a214c7
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 13:06:27 2014 -0500

    make pretty for pc users

commit a7816c4
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 12:01:40 2014 -0500

    fix self as source dissappearing on media insert

    fixes #95

commit 1159d17
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 11:30:01 2014 -0500

    fix missing timeline placeholder icon

commit 63d1fef
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 09:23:53 2014 -0500

    update translation strings

commit 46f597d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 09:23:19 2014 -0500

    link to the post admin if empty map to setup markers

commit 0762ca6
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 09:10:38 2014 -0500

    changelog

commit b42c700
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 09:10:05 2014 -0500

    Maps: better text bubble handling

    avoid an empty bubble on markers with no text entered

commit adce0b9
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 09:03:28 2014 -0500

    restructure map meta function to be universal

commit 3508256
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 08:56:10 2014 -0500

    changelog

commit 57fb313
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 08:44:24 2014 -0500

    Maps: automatic marker fallback if view empty

    if the user has not entered a starting coordinate, fallback to the first coordinate that they have entered and warn logged in users

    fixes #66

commit 0b0fa17
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Sep 14 08:01:50 2014 -0500

    Maps: warn user on front end if no markers are entered

    prevents confusing empty state

    ref #66

commit 8152eb7
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 18:00:25 2014 -0500

    update translation strings

commit 1f34b2f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 17:33:43 2014 -0500

    collections component height tweaks

commit c2ee4dc
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 17:29:17 2014 -0500

    more semantics and set specific cache key

    for splash query in collections component

commit 3877cc7
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 17:22:57 2014 -0500

    semantics

commit 13bc8af
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 17:10:36 2014 -0500

    content component responsive to mobile

commit de9f08a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 17:01:07 2014 -0500

    fix floater position and alignment in content component

commit 84b243a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 16:51:03 2014 -0500

    content component floater direction

    default to down instead of up

commit 0e749d6
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 13 16:50:13 2014 -0500

    content component parallax floater optimizations

    only run parallax if floater in view and autocalculate offsets

commit 4b1116b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 12 17:02:19 2014 -0500

    fix update/insert again

commit 40dbaf4
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 12 16:57:46 2014 -0500

    final responsive

commit b23e647
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 12 16:26:19 2014 -0500

    50% width on small height - responsive

commit 205b621
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 12 11:59:48 2014 -0500

    mo responsive

    http://cl.ly/image/2T121O0N2n22

commit 5fcb600
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 12 11:18:36 2014 -0500

    start responsive and fix the button display:none

commit 0caf61f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 11 08:57:04 2014 -0500

    fix slug for i18n

commit a6901e5
Author: E.T.Cook <e@etc.io>
Date:   Wed Sep 10 17:08:45 2014 -0500

    Fix #110

commit 4adf2ca
Author: E.T.Cook <e@etc.io>
Date:   Wed Sep 10 15:47:43 2014 -0500

    Attempt at #127

commit 7d4ac3b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Sep 9 17:19:28 2014 -0500

    sticky "insert component" button

commit 436aaae
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 8 16:18:00 2014 -0500

    update strings

commit d58fffd
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Sep 6 14:20:47 2014 -0500

    fixes #130

commit dbdc217
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 5 18:06:50 2014 -0500

    1.0.94 - Beta 4

commit 7fed3c0
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 5 18:04:50 2014 -0500

    expanded Help tab text + update translatable strings

commit 194ee90
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 5 15:47:22 2014 -0500

    changelog

commit f19ee7a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Sep 5 15:09:33 2014 -0500

    fix captions and titles in galleries

    plus add captions to grid gallery fixes #129

commit 0e7868a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:36:22 2014 -0500

    update strings

commit 0bc5123
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:28:12 2014 -0500

    cherry pick accidnetal commits to master

commit 3750193
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:10:16 2014 -0500

    prev commit fixes #126

    fixes #126

commit f4db49d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:09:47 2014 -0500

    fix odd syntax

commit 629aa6f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:04:46 2014 -0500

    changelog

commit 8f6822e
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 19:01:42 2014 -0500

    second pass improved timeline component

    http://cl.ly/image/1E2E16463527

commit 98749ab
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 18:26:52 2014 -0500

    first pass revamped timeline component

    * this is a breaking change *

    the filter for aesop_timeline_scroll_container has chnage to article from 'entry-content'. this means the timeline component is now compatible with 99% of themes.

commit 05caf74
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Sep 4 16:01:47 2014 -0500

    comment out console logging

commit 8f98b7b
Author: Jenny <jenny@simplemama.com>
Date:   Thu Sep 4 16:02:37 2014 -0400

    Removes px next to input boxes

    Fixes remaining on #125

commit 24f5579
Author: Jenny <jenny@simplemama.com>
Date:   Thu Sep 4 15:50:58 2014 -0400

    Editor grammar / spelling fixes

    Fixes #125

commit a4ef85c
Merge: 7a4fa5b 1a3305a
Author: Nick Haskins <email@nickhaskins.com>
Date:   Wed Sep 3 20:25:49 2014 -0500

    Merge pull request #121 from michaelbeil/patch-3

    changed "for" to "of" to clarify

commit 1a3305a
Author: Michael Beil <michaelbeil@me.com>
Date:   Wed Sep 3 20:24:49 2014 -0500

    changed "for" to "of" to clarify

commit 7a4fa5b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 20:21:28 2014 -0500

    ixnay periods in LLC props @michaelbeil

commit bdb1f7f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 19:54:30 2014 -0500

    add link in generator to donate to aesop and linsk to site

    define('AI_CORE_WATERMARK',false);

    to remove

commit ea37057
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 18:11:43 2014 -0500

    ixnay clipboard control

    ref #116

    - lack of scissors icon woudl mean converting to font awesome
    - lack of fixed clipboard icon leaves users wondering where the component went after being cut

    Basically not good enough for launch.

commit e992678
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 18:06:26 2014 -0500

    more robust and efficient waypoint filters for audio/video

    ref #83

commit 661b2da
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 16:53:17 2014 -0500

    update title for clicpboard

commit 59c3326
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Sep 3 16:25:02 2014 -0500

    fix the project link doh props @simplemama

commit ca65546
Merge: 007c992 531d7e1
Author: Nick Haskins <email@nickhaskins.com>
Date:   Tue Sep 2 19:37:18 2014 -0500

    Merge pull request #111 from michaelbeil/patch-2

    Deleted an unnecessary 'the' in uploading in wp

commit 531d7e1
Author: Michael Beil <michaelbeil@me.com>
Date:   Tue Sep 2 19:34:13 2014 -0500

    Deleted an unnecessary 'the' in uploading in wp

commit 007c992
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Sep 2 18:02:08 2014 -0500

    update @etc username on .org

commit 6d41a56
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 2 17:47:01 2014 -0500

    Fixed #101

commit f3a55ce
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 2 17:30:02 2014 -0500

    underscores

commit a647d24
Merge: a690d9f 154aa51
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 2 17:28:36 2014 -0500

    Merge branch 'dev' of github.com:bearded-avenger/aesop-core into dev

    Conflicts:
    	admin/assets/js/tinymce/aiview/plugin.js
    	admin/assets/js/tinymce/aiview/plugin.min.js

commit a690d9f
Author: E.T.Cook <e@etc.io>
Date:   Tue Sep 2 17:19:39 2014 -0500

    Issue with regex and underscore #90

commit 154aa51
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 18:14:01 2014 -0500

    eliminate cached option queries until we can separate views

    fixes posts appearing in other add-on post optoins

commit b27a6f2
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 16:53:27 2014 -0500

    fix bug with image upload option type

commit 8a537ab
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 13:39:43 2014 -0500

    lower the image crop factor for parallax

    due to recent optimization

commit 21a75b5
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 12:56:24 2014 -0500

    height/width not needed since lazy update

commit faef736
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 10:20:10 2014 -0500

    update strings

commit f61ccc9
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 10:18:06 2014 -0500

    titles to button controls

commit 2e65a8d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 08:51:15 2014 -0500

    new screenshot for readme

commit 4008531
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 08:16:52 2014 -0500

    ASE 1.1 - Beta 3

commit 39e7c3a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 08:16:17 2014 -0500

    4.0 compatibiltiy notice

commit 6dcde8b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Sep 1 08:15:43 2014 -0500

    changelog

commit 16d1958
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Aug 31 15:20:09 2014 -0500

    misc generator style tweaks

commit c3f23cf
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Aug 31 12:20:23 2014 -0500

    expand scope of media waypoints

    fixes #83

commit 9aaa268
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sun Aug 31 07:52:39 2014 -0500

    cache the queries for fetching option types

commit 6be2490
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 17:09:10 2014 -0500

    correct video component icon for placeholder

commit c166244
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 16:43:16 2014 -0500

    changelog

commit 1c010f7
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 16:42:21 2014 -0500

    RTL support

    fixes #67

commit c49f3fa
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 15:17:01 2014 -0500

    new helper for addon api aesop_option_counter($count)

    used to fascilate easy creation of integer based dropdown options

commit 82e964e
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 14:58:25 2014 -0500

    general cleanup

commit c976a49
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 14:46:31 2014 -0500

    fix quote cite attribute type

commit dbcb125
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 14:38:07 2014 -0500

    remove a few more un-needed attributes due to automatic calculations

commit 93f4d9b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 14:32:56 2014 -0500

    automatic offsets means no need for offset attribute as a hack

commit 84a2ded
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 13:46:39 2014 -0500

    tweak offset position of floater

commit cd47e02
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 13:10:08 2014 -0500

    auto create alt tag for character component image

commit ef403d2
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 13:07:26 2014 -0500

    automatic alt tag fallback

    for image component if no alt tag specified

commit 5296352
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 30 09:08:24 2014 -0500

    better support for chapter component in non-aesop themes

    tested and pictured in Genesis theme below
    http://cl.ly/image/2b271e2S0g26

commit 47ac546
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 29 15:55:12 2014 -0500

    changelog

commit 9e40d00
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 29 14:09:04 2014 -0500

    antialiasing to components in editor

commit be34bd3
Author: E.T.Cook <e@etc.io>
Date:   Fri Aug 29 01:52:49 2014 -0500

    Fixed #104

commit bc031a0
Author: E.T.Cook <e@etc.io>
Date:   Fri Aug 29 01:12:40 2014 -0500

    Fixed #99

commit 35b81bf
Author: E.T.Cook <e@etc.io>
Date:   Fri Aug 29 00:24:01 2014 -0500

    Fixed #100

commit b085020
Author: E.T.Cook <e@etc.io>
Date:   Thu Aug 28 19:56:21 2014 -0500

    fix line break issue

commit 9c7b04c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 28 14:42:55 2014 -0500

    checks

commit 92df40f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 25 19:10:42 2014 -0500

    fix values error TISK TISK

commit bdbfd84
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 25 16:23:25 2014 -0500

    more phase out unused label att

commit 19aba2d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 25 16:18:47 2014 -0500

    phase out the un-used "label" attribute in chapter heading

commit 5e733e1
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 25 16:08:57 2014 -0500

    chapter to target chapter write

    fixes chapter scrollnav not closing sections

commit 833115e
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 25 14:43:52 2014 -0500

    misc ui tweaks

commit 0a554eb
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 23 11:33:46 2014 -0500

    update translation strings

commit 343dd63
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 23 11:31:58 2014 -0500

    tweak padding on genny settings panel

commit 067f79b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 23 11:28:56 2014 -0500

    color coordinate like options for less confusion + move some opts

commit 8ec6866
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 23 10:58:01 2014 -0500

    punt conditional option loading

commit 5fd8ee2
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 23 08:40:56 2014 -0500

    set cookies for open option states

    ref #89

commit 094aa47
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 20:39:13 2014 -0500

    automatically feed in categories so user doesnt have to enter id

commit d102534
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 19:23:03 2014 -0500

    1.0.92 beta

commit 5b6cf8a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 19:19:32 2014 -0500

    better masking

commit 5457845
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 18:51:21 2014 -0500

    small screen responsive support

commit 4058b5d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 16:07:36 2014 -0500

    update translation strings

commit a4928a4
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 16:01:58 2014 -0500

    set default option post retriever to posts

commit f8c331b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 15:13:47 2014 -0500

    fix option type

commit 4e9a83d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 15:09:36 2014 -0500

    whoops! forgot one

commit 2d8035b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 15:08:21 2014 -0500

    clean out empty value arrays

commit 3048e34
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 14:52:14 2014 -0500

    proper gallery icon + comment function arg

commit 38e8037
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 14:47:07 2014 -0500

    better helper function for retrieving posts for options

commit f26357f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 14:39:01 2014 -0500

    i18n

commit 9529261
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 13:44:14 2014 -0500

    1.0.91 - beta

commit a89e802
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 13:40:45 2014 -0500

    icon/mask tweaks

commit e740cb3
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 12:56:53 2014 -0500

    cleanup + better select opts logic + let users select gallery in generator

commit dfe3609
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 11:07:15 2014 -0500

    control button spacing hover state

commit c83d529
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 11:01:18 2014 -0500

    style tweaks to placeholders

commit 509f65c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 10:44:40 2014 -0500

    recompile

commit 2893bb8
Merge: 90b2d36 3859a79
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 10:42:38 2014 -0500

    Merge branch 'master' of github.com:etcook/aesop-core into etcook-master

    Conflicts:
    	admin/assets/js/generator.js.map
    	admin/assets/js/generator.min.js

commit 3859a79
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 09:59:07 2014 -0500

    do gallery icon and fix admin stylesheet

commit 2aa3b36
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 08:41:21 2014 -0500

    gallery to genny

commit ab40fbd
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 22 07:18:41 2014 -0500

    mask

commit 83ee8c1
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 21 17:02:52 2014 -0500

    do missing component icons in placeholders

commit 740c285
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 21 14:08:58 2014 -0500

    action for 3rd party add-ons hooking into css for icon

commit 9b7d6a1
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 21:25:46 2014 -0500

    protecting the component regions

commit db9fdf7
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 19:12:08 2014 -0500

    fixes

commit 4b8b16a
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 16:04:35 2014 -0500

    clipboard

commit 2d1885f
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 15:19:28 2014 -0500

    handle the controls manually

commit d57a6ef
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 15:04:09 2014 -0500

    console logs

commit 523133d
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 14:59:26 2014 -0500

    copy and paste

commit 523d1a1
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 13:12:29 2014 -0500

    changes

commit 0a747e4
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 11:23:52 2014 -0500

    fixes

commit a77c10b
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 10:35:53 2014 -0500

    js

commit 2171d3a
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 10:34:12 2014 -0500

    updates

commit a133a7b
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 20 09:47:37 2014 -0500

    cleanup in master branch

commit 5d70167
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 20:13:05 2014 -0500

    fix enters outside of the box

commit 723e638
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 19:59:26 2014 -0500

    take over enter

commit 54f880c
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 18:04:48 2014 -0500

    noneditable

commit 5966c30
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 17:46:59 2014 -0500

    my fault

commit 49e01aa
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 17:44:41 2014 -0500

    try to retain the breaks

commit d610170
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 17:36:14 2014 -0500

    activate min + mapping

commit dc3f895
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 17:34:42 2014 -0500

    minified versions

commit 60db8d3
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 17:26:26 2014 -0500

    filter out tinymce leftovers from line breaks

commit 44c958e
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 16:32:57 2014 -0500

    comments

commit ed54b7a
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 16:24:30 2014 -0500

    recognize content and inject

commit 9c67bb3
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 16:10:48 2014 -0500

    fix

commit 90b2d36
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Aug 19 14:08:41 2014 -0500

    conditional loading of options

    for example, don't show the parallax options in quote component if the user has set it to off

commit 6a9c7dd
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Aug 19 12:55:40 2014 -0500

    gallery image size filters

    fixes #86

commit a1dd648
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 02:08:02 2014 -0500

    fix issue with shortcodes with no options

commit 912b8ee
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 01:50:26 2014 -0500

    allow insertions

commit 058b68a
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 01:39:00 2014 -0500

    some js fixes

commit 99bec41
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 19 00:37:17 2014 -0500

    bring up the new modal

commit abae15c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 18 12:59:11 2014 -0500

    fix the shit

commit cd939c6
Author: E.T.Cook <e@etc.io>
Date:   Mon Aug 18 12:49:45 2014 -0500

    changes

commit 9d4d855
Merge: e1e1cc1 e6854eb
Author: E.T.Cook <e@etc.io>
Date:   Mon Aug 18 12:40:48 2014 -0500

    Merge branch 'dev' of github.com:bearded-avenger/aesop-core

    Conflicts:
    	admin/assets/js/generator.min.js
    	admin/class-aesop-core-admin.php

commit e1e1cc1
Author: E.T.Cook <e@etc.io>
Date:   Sun Aug 17 20:50:33 2014 -0500

    settings

commit 849da36
Author: E.T.Cook <e@etc.io>
Date:   Sun Aug 17 20:00:12 2014 -0500

    objectify the shortcodes

commit f869557
Author: E.T.Cook <e@etc.io>
Date:   Sun Aug 17 19:45:42 2014 -0500

    getting the array

commit ada5467
Author: E.T.Cook <e@etc.io>
Date:   Sun Aug 17 18:20:30 2014 -0500

    scope the sections

commit e6854eb
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 16 08:20:42 2014 -0500

    gallery edit content fix + pretty error

commit 08a8e3c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 16 08:10:26 2014 -0500

    fix merge

commit da46b2e
Merge: 394c2cd 88f9093
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 16 08:08:23 2014 -0500

    Merge branch 'release/1.1' into dev

    Conflicts:
    	public/includes/components/component-heading.php

commit 88f9093
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 16 07:55:34 2014 -0500

    improved chapter heading markup

commit 97ede5a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 20:04:07 2014 -0500

    more gallery desc fix

commit 1723e30
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 20:01:37 2014 -0500

    clean up desc

commit ae76c0d
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 19:58:21 2014 -0500

    rename add media to add gallery in gallery creation

commit 1f41996
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 19:39:37 2014 -0500

    more cleanup not needed items in gallery creation screen

commit 5703eda
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 19:35:54 2014 -0500

     cleanup gallery admin interface

commit 1ed9c99
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 16:17:37 2014 -0500

    automatically configure the offset distance for parallax floater

commit 8b53ded
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 14:36:48 2014 -0500

    fix comments

commit bc0f933
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 14:34:05 2014 -0500

    cache gallery retrieval

commit 0742765
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 13:24:03 2014 -0500

    Math.round to parallax transform y pos

commit 7c51326
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 13:21:02 2014 -0500

    stray id

commit fcb4db3
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 13:19:06 2014 -0500

    optimize parallax for quote component

    only animate if in view

commit c77fb6c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 13:06:17 2014 -0500

    filters for audio/video waypoints

    fixes #83

commit c178abd
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 12:59:25 2014 -0500

    floater position fixes

    fixes #84

commit 2cfbc59
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 12:25:43 2014 -0500

    parallax + parallax floater optimizations

    don't run parallax if the component is not within view

commit 19d2ac9
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 15 08:54:47 2014 -0500

    various generator field improvements

    new text area field, new text small field, new prefix to make sure correct info is entered

commit 7b8e96c
Author: E.T.Cook <e@etc.io>
Date:   Fri Aug 15 01:30:12 2014 -0500

    edit

commit 071f396
Author: E.T.Cook <e@etc.io>
Date:   Fri Aug 15 00:21:59 2014 -0500

    listener method for posterity

commit 0d5b446
Author: E.T.Cook <e@etc.io>
Date:   Thu Aug 14 22:23:05 2014 -0500

    fix the visual and text states

commit 4caeb8e
Author: E.T.Cook <e@etc.io>
Date:   Thu Aug 14 19:55:44 2014 -0500

    allow html

commit dd6c4c1
Author: E.T.Cook <e@etc.io>
Date:   Thu Aug 14 19:18:22 2014 -0500

    content updates

commit 1743826
Author: E.T.Cook <e@etc.io>
Date:   Thu Aug 14 18:46:19 2014 -0500

    new handlers

commit 74e0c9b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 14 18:09:34 2014 -0500

    clean up un-used vars

commit 4caa3d7
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 14 18:02:31 2014 -0500

    more gallery component refinements

commit 8d1b7c0
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Thu Aug 14 14:48:08 2014 -0500

    optimized gallery retrieval

    get_post_gallery replaces BOTH the call to get_posts AND the regex needed to scrape the gallery for image ids. also include a warning if wrong gallery ID or no images found

commit 28fc3aa
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 16:55:10 2014 -0500

    dont run genny markup where it's not supposed to be

commit 636ddc6
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 15:38:14 2014 -0500

    tweak to colors

commit 5e3f07c
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 13:48:28 2014 -0500

    style tweaks to new UI

commit 95f5793
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 13:36:15 2014 -0500

    modal close button

commit f261b1f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 11:45:43 2014 -0500

    ditch tooltips, go with small desc

commit a8de23f
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 10:53:48 2014 -0500

    more new generator work

commit bb45b3e
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 10:12:20 2014 -0500

    keyup escape and styles

commit bd8dcee
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 13 09:54:14 2014 -0500

    new ui

commit b168452
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 13 01:27:12 2014 -0500

    try to control editability more

commit b9a907c
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 13 01:21:01 2014 -0500

    fix logic based on shortcode type

commit 6890476
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 13 01:03:23 2014 -0500

    interface updates

commit 9767f23
Author: E.T.Cook <e@etc.io>
Date:   Wed Aug 13 00:33:32 2014 -0500

    fleshing it out

commit efe6f91
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 12 23:35:34 2014 -0500

    styles

commit 1ef3799
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 12 22:52:40 2014 -0500

    that was a bitch

commit ba2f6a5
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 12 15:54:05 2014 -0500

    code cleanup

commit c1745a1
Author: E.T.Cook <e@etc.io>
Date:   Tue Aug 12 00:17:41 2014 -0500

    integration of mce plugin and views

commit 3607c82
Author: E.T.Cook <e@etc.io>
Date:   Mon Aug 11 22:47:35 2014 +0000

    update

commit 7cd1df2
Author: E.T.Cook <e@etc.io>
Date:   Mon Aug 11 21:09:23 2014 +0000

    composer.json

commit 394c2cd
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 11 15:18:07 2014 -0500

    swap width/height

commit 662ebf1
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Mon Aug 11 15:13:40 2014 -0500

    images need height/width if lazy loading

commit 409eccb
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Fri Aug 8 10:14:37 2014 -0500

    updated translation files

commit b7abd28
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Wed Aug 6 19:01:55 2014 -0500

    fix lazy on image component

commit 5a4288a
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Aug 5 17:52:04 2014 -0500

    map location filter

commit 3a5db2b
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Aug 5 17:51:07 2014 -0500

    chapter/timeline location filters

    filters to determine where chapter and timeline can be loaded. useful for using on pages.

commit a6944b0
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Tue Aug 5 15:23:37 2014 -0500

    fixes for aesop lazy loader integration

commit 6e48134
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 2 13:40:57 2014 -0500

    lazy loader support chapter img bg

commit 1b1db58
Author: Bearded Avenger <email@nickhaskins.com>
Date:   Sat Aug 2 13:27:45 2014 -0500

    better support aesop lazy loader
etcook added a commit that referenced this issue Oct 7, 2014
@etcook
fix #127
96fc242
@etcook etcook closed this as completed Oct 7, 2014
etcook added a commit that referenced this issue Oct 7, 2014
@etcook
fix #127
27f1465
@bearded-avenger
Copy link
Collaborator

I reopened this issue because this is still happening periodically and had another user report this. I'm thoroughly testing all components due to work with escaping attributes and in my testing I've found that, on occasion, updating a component, adds the   after the component. It doesn't happen all the time. The ONLY time it's predicable is when its up against another component.

This was a fix for #138

It does however happen on single components and can be frustrating for the end user. Hopefully we can find a solid way to alleviate this in the devil that is Tiny MCE.

@bearded-avenger bearded-avenger added this to the 1.3 milestone Nov 8, 2014
@bearded-avenger
Copy link
Collaborator

I think i can fix this with a strtr on the_content filter. It'll keep the space for tinymce but will strip it out for display ONLY if it follows after or before a shortcode.

bearded-avenger pushed a commit that referenced this issue Nov 9, 2014
remove paragraphs taht only contain &nbsp;
0f74290 
fixes #127
@bearded-avenger
Copy link
Collaborator

This may come back to bite us in the ass later. It will remove any pagraph tag if it only has an empty space. I can only see one reason this would be unexpected, is if a user is using empty paragraphs as a way of adding margin because they dont know or dont want to do any css.

@bearded-avenger
Copy link
Collaborator

P.S - this should honestly be cleaned up and condensed into one method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etcook etcook

Labels
bug editor
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
4 participants
@bearded-avenger @etcook @michaelbeil @TheAnarchyState