Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the allowed versions of the required requests package? #26

Closed
philgyford opened this issue Mar 25, 2022 · 2 comments · Fixed by #27
Closed

Expand the allowed versions of the required requests package? #26

philgyford opened this issue Mar 25, 2022 · 2 comments · Fixed by #27

Comments

@philgyford
Copy link

I've just tried to install django-wm but hit an issue where its specified version of requests is older than that allowed by other packages I'm already using.

setup.cfg specifies requests ~= 2.20.0, so anything like 2.20.*. But requests is now up to 2.27.1.

Other things I'm using in this project, as examples, have >=2.2.1 (flickrapi), >=2.1.0 (twython), >=2.0,<3.0 (responses).

Any chance it could be given a more lenient requirement?

(Sorry, after coming here ages ago to ask about a non-celery version of django-wm, I disappeared and only now have I found time to get to grips with it again... and here I am causing trouble once more! These kinds of interrelated dependencies can be such a pain and I only assume I haven't hit a similar problem with my own packages because nobody uses them :) Thanks for your time.)

philgyford added a commit to philgyford/django-wm that referenced this issue Mar 26, 2022
Trying out changing `requests` from only `2.20.*` to `>= 2.20.0, < 3.0.0`

And `beautifulsoup4` from only `4.6.*` to `>= 4.6.3, < 4.12.0` (latest unreleased version is 4.11, which doesn't look like it has any breaking changes beyond those in 4.10)

I'll try it out and see if anything breaks!

For beatonma#26
@beatonma beatonma mentioned this issue Mar 26, 2022
@beatonma
Copy link
Owner

2.2.0 is now available. It should now accept >=2.20,<3.0. Likewise for beautifulsoup and the others.

No problem! Likewise - I hadn't touched this project in a long time and wasn't aware of anyone using it. Having some users who are interested in making it better is a good problem to have :)

@philgyford
Copy link
Author

Thank you so much, very speedy! I've successfully added it locally, and look forward to trying to get it all working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants