New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable warnings during test suite execution and fix most of them #15

Merged
merged 9 commits into from Aug 30, 2016

Conversation

Projects
None yet
2 participants
@ivoanjo
Copy link
Contributor

ivoanjo commented Aug 28, 2016

One of the projects I am involved with makes use of the configurations gem (thanks so much for your work, btw!) and we recently turned on the rspec option to run our specs with warnings, which helped us fix a lot of warnings, but also got us a lot of warnings from gems we use.

So I'm now embarking on a quest to solve as many warnings as I can, so we can get clean specs again :)

I was able to fix most of the warnings I got when running the configurations specs, and I hope my approach is acceptable. I also found a bug in the test_configure_synchronized.rb spec that was resulting in a warning.

Thanks for your consideration!

@beatrichartz beatrichartz merged commit bf03251 into beatrichartz:master Aug 30, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@beatrichartz

This comment has been minimized.

Copy link
Owner

beatrichartz commented Aug 30, 2016

Brilliant, thanks for this! - I will take some time looking at the remaining warnings later this week.

Out of interest, how are you using configurations in your setup?

@ivoanjo

This comment has been minimized.

Copy link
Contributor Author

ivoanjo commented Aug 31, 2016

Hello! Thanks for the quick answer :)

We're using it @Talkdesk to allow configuration for a gem to access an in-house API. (Hopefully both the gem and the API will be public in the near future).
On previous gems we DIYd the configuration, but decided against doing it for this one, and configurations suited us very well.

On the gem itself we have a simple setup where we setup defaults on configurations based on env vars, but allow users to change them. We have regexes for a couple of options allowing the env vars to be enabled with yes/true/1, but other than that it's pretty straightforward.

@beatrichartz

This comment has been minimized.

Copy link
Owner

beatrichartz commented Sep 10, 2016

Your changes are released in 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment