-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving npm package upstream #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions and defaults.
Closed
Also, I am totally open to rebasing all of these changes into one gigantic commit. It would be a shame to lose the history, though. |
I don't see any reason to squash them. Your changes are basically orthogonal to the scripts and LGTM. I see no reason not to merge and if @einars has any feedback we can make further changes. |
bitwiseman
added a commit
that referenced
this pull request
Mar 19, 2013
Moving npm package upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As convenient as
git
and GitHub make maintaining a very lightweight fork (virtually no modifications to existing code), I think it's time to fold mynpm
package back into the core.Since the project is a Python/JS hybrid, of sorts, I did not follow the conventional
npm
source organization (bin
andlib
dirs, etc). These are things we can decide later, if desired (they're not required, just convention).Lamentably, I have not written tests for the CLI interface I wrote (though I have exhaustively tested it in practice). This is largely because of the difficulty of integrating the existing functional tests with a convenient npm-based test framework like Mocha or Vows. I have experience with both frameworks, and am willing to contribute framework-based tests in the future.
Following the
npm
convention, the existing tests can be run vianpm test
in the project root. (Controlled by thescripts
property of package.json)Once merged, we'll need to modify the
repository.url
and possibly thecontributors
list (I just pulled what I could find fromindex.html
and theREADME
. As long as we're still using thejs-beautify
package identifier fornpm
, I can add @einars and @bitwiseman as owners (after you create accounts vianpm
's adduser subcommand), which would allow you to publish new versions to the npm registry.I would be happy to effect these changes in the core repo directly, if you're willing to give me contributor access. Otherwise, I'll just make another pull request (adding ownership regardless).