Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using alias in DATE_ADD #243

Merged
merged 2 commits into from Dec 1, 2017
Merged

Conversation

eigan
Copy link
Contributor

@eigan eigan commented Feb 22, 2017

Same changes as in pull #230 and issue #218 for DateDiff.

Tests will probably fail in Doctrine 2.2 like #239.

@stevelacey
Copy link
Contributor

Hm, why haven't the tests ran... dammit Travis

@stevelacey
Copy link
Contributor

@eigan any progress with these two PR's? tests are failing

@eigan
Copy link
Contributor Author

eigan commented Mar 17, 2017

I will take a look this weekend @stevelacey

@eigan
Copy link
Contributor Author

eigan commented Mar 20, 2017

Tests only fails with Doctrine 2.1.*. And looks to be something about not finding 'alternative' (the alias).

The 2.2 blog post mentions something about alias. This commit was added to 2.2 and has adjustments to SqlWalker..

Do you know anything regarding alias and Doctrine 2.1?

@stevelacey
Copy link
Contributor

@eigan looks like aliases weren't supported in 2.1 – it's probably acceptable to check the Doctrine version and early return at the start of your test if <2.2

@eigan
Copy link
Contributor Author

eigan commented Oct 22, 2017

@stevelacey Marked test as skipped in < 2.2

@stevelacey stevelacey merged commit a7957e5 into beberlei:master Dec 1, 2017
@stevelacey
Copy link
Contributor

@eigan thanks for your contribution 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants